Keep textual output format matching old

Author: jpienaar

mlir/lib/IR/AsmPrinter.cpp

@@ -2014,15 +2014,6 @@ void AsmPrinter::Impl::printLocationInternal(LocationAttr loc, bool pretty,
           os << loc.getFilename().getValue();
         else
           printEscapedString(loc.getFilename());
-        if (loc.getStartLine() == 0 && loc.getStartColumn() == 0 &&
-            loc.getEndLine() == 0 && loc.getEndColumn() == 0) {
-          return;
-        }
-        if (loc.getStartColumn() == 0 &&
-            loc.getStartLine() == loc.getEndLine()) {
-          os << ':' << loc.getStartLine();
-          return;
-        }
         if (loc.getEndColumn() == loc.getStartColumn() &&
             loc.getStartLine() == loc.getEndLine()) {
           os << ':' << loc.getStartLine() << ':' << loc.getStartColumn();

mlir/test/IR/locations.mlir

@@ -33,7 +33,7 @@ func.func @inline_notation() -> i32 {
 // CHECK-LABEL: func private @loc_attr(i1 {foo.loc_attr = loc(callsite("foo" at "mysource.cc":10:8))})
 func.func private @loc_attr(i1 {foo.loc_attr = loc(callsite("foo" at "mysource.cc":10:8))})
 
-// CHECK-LABEL: func.func private @filelocrange_attr1(i1 {foo.loc_attr = loc("mysource.cc":10)})
+// CHECK-LABEL: func.func private @filelocrange_attr1(i1 {foo.loc_attr = loc("mysource.cc":10:0)})
 func.func private @filelocrange_attr1(i1 {foo.loc_attr = loc("mysource.cc":10)})
 // CHECK-LABEL: func.func private @filelocrange_attr2(i1 {foo.loc_attr = loc("mysource.cc":10:8)})
 func.func private @filelocrange_attr2(i1 {foo.loc_attr = loc("mysource.cc":10:8)})