Skip to content

Commit cedf670

Browse files
committed
Update documentation wording
1 parent b793ecf commit cedf670

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPU.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def AMDGPU_FatRawBufferCastOp :
186186
If `validBytes` is given, it is the number of bytes that will be valid as
187187
an offset to `out`. If it is not provided, this will be inferred from
188188
the size of the memref during lowering. This size is
189-
max_d (sizes[d] * strides[d]) * sizeof(element type)..
189+
max_{d = 0 upto rank(source)} (sizes[d] * strides[d]) * sizeof(element type).
190190

191191
The flags of the buffer descriptor will be set up to enable raw usage -
192192
for example, stride = 0, add_tid = 0, and so on. The `boundsCheck`

mlir/include/mlir/Dialect/AMDGPU/Transforms/Passes.td

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,13 @@ def AmdgpuResolveStridedMetadataPass : Pass<"amdgpu-resolve-strided-metadata"> {
3737
This pass rrewrites `memref.extract_strided_metadata` operations
3838
targeting the AMDGPU dialect casts.
3939

40-
It's mainly meant for testing - please incorporate the patterns into your
41-
own extract-strided-metadata passes (or run memref's expand-strided-metadata
42-
again after this).
40+
The patterns in this pass should normally be run alongside those in
41+
-expand-strided-metadata, and creating a pass that combines those two
42+
sets of patterns is the recommended way to use this functionality.
43+
However, this pass (which will likely need a second -expand-strided-metadata
44+
after it) is provided so that simple usecases do not need to create custom passes.
45+
These patterns have not been added to -expnad-strided-metadata to
46+
prevent the memref dialect from depending on platform-specific code.
4347
}];
4448
let dependentDialects = [
4549
"arith::ArithDialect",

0 commit comments

Comments
 (0)