Skip to content

Commit cef2539

Browse files
add comment
1 parent 519fcc5 commit cef2539

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

libc/src/setjmp/setjmp_impl.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,15 @@
1717

1818
namespace LIBC_NAMESPACE_DECL {
1919

20+
// TODO(https://github.com/llvm/llvm-project/issues/112427)
21+
// Some of the architecture-specific definitions are marked `naked`, which in
22+
// GCC implies `nothrow`.
23+
//
24+
// Right now, our aliases aren't marked `nothrow`, so we wind up in a situation
25+
// where clang will emit -Wmissing-exception-spec if we add `nothrow` here, but
26+
// GCC will emit -Wmissing-attributes here without `nothrow`. We need to update
27+
// LLVM_LIBC_FUNCTION to denote when a function throws or not.
28+
2029
#ifdef LIBC_COMPILER_IS_GCC
2130
[[gnu::nothrow]]
2231
#endif

0 commit comments

Comments
 (0)