Add assert tests for preconditions

Author: smallp-o-p

libcxx/include/__text_encoding/te_impl.h

@@ -359,7 +359,8 @@ struct __te_impl {
   }
 
   _LIBCPP_HIDE_FROM_ABI static constexpr const __te_data* __find_encoding_data(string_view __a) {
-    _LIBCPP_ASSERT(__a.size() <= __max_name_length_, "Passing encoding name longer than max_name_length!");
+    _LIBCPP_ASSERT_ARGUMENT_WITHIN_DOMAIN(
+        __a.size() <= __max_name_length_ && !__a.contains('\0'), "invalid string passed to text_encoding(string_view)");
     const __te_data* __data_first = __text_encoding_data + 2;
     const __te_data* __data_last  = std::end(__text_encoding_data);
 
@@ -377,8 +378,9 @@ struct __te_impl {
   }
 
   _LIBCPP_HIDE_FROM_ABI static constexpr const __te_data* __find_encoding_data_by_id(__id __i) {
-    _LIBCPP_ASSERT(__i >= __id::other && __i <= __id::CP50220 && int_least32_t(__i) != 33 && int_least32_t(__i) != 34,
-                   "Passing invalid id to text_encoding constructor!");
+    _LIBCPP_ASSERT_ARGUMENT_WITHIN_DOMAIN(
+        ((__i >= __id::other && __i <= __id::CP50220) && ((int_least32_t(__i) != 33) && (int_least32_t(__i) != 34))),
+        "invalid text_encoding::id passed to text_encoding(id)");
     auto __found =
         std::lower_bound(std::begin(__text_encoding_data), std::end(__text_encoding_data), int_least32_t(__i));
 

libcxx/test/libcxx/utilities/text_encoding/text_encoding.ctor/assert.id.pass.cpp

@@ -0,0 +1,34 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: std-at-least-c++26
+// REQUIRES: libcpp-hardening-mode={{extensive|debug}}
+
+// <text_encoding>
+
+// text_encoding text_encoding(id)
+
+#include <climits>
+#include <text_encoding>
+
+#include "check_assertion.h"
+
+int main(int, char**) {
+  // Make sure that text_encoding(id) asserts when the input id not in range of allowed values
+
+  TEST_LIBCPP_ASSERT_FAILURE(
+      std::text_encoding(std::text_encoding::id(33)), "invalid text_encoding::id passed to text_encoding(id)");
+  TEST_LIBCPP_ASSERT_FAILURE(
+      std::text_encoding(std::text_encoding::id(34)), "invalid text_encoding::id passed to text_encoding(id)");
+  TEST_LIBCPP_ASSERT_FAILURE(
+      std::text_encoding(std::text_encoding::id(-1)), "invalid text_encoding::id passed to text_encoding(id)");
+  TEST_LIBCPP_ASSERT_FAILURE(
+      std::text_encoding(std::text_encoding::id(INT_MAX)), "invalid text_encoding::id passed to text_encoding(id)");
+
+  return 0;
+}

libcxx/test/libcxx/utilities/text_encoding/text_encoding.ctor/assert.string_view.pass.cpp

@@ -0,0 +1,37 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: std-at-least-c++26
+// REQUIRES: libcpp-hardening-mode={{extensive|debug}}
+
+// <text_encoding>
+
+// text_encoding text_encoding(string_view)
+
+#include <string_view>
+#include <text_encoding>
+
+#include "check_assertion.h"
+
+int main(int, char**) {
+  char str[std::text_encoding::max_name_length + 2] =
+      "HELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELL";
+  std::string_view view(str);
+
+  // text_encoding(string_view) asserts if its input size() > max_name_length
+  TEST_LIBCPP_ASSERT_FAILURE(std::text_encoding(view), "invalid string passed to text_encoding(string_view)");
+
+  // text_encoding(string_view) asserts if its input contains a null terminator
+  char str2[std::text_encoding::max_name_length] = "HELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELLOHELL";
+  std::string_view view2(str2);
+  str2[3] = '\0';
+
+  TEST_LIBCPP_ASSERT_FAILURE(std::text_encoding(view2), "invalid string passed to text_encoding(string_view)");
+
+  return 0;
+}