Skip to content

Commit cf4e8e3

Browse files
arsenmarsenm
committed
CodeGen: Remove TRI arguments from stack load/store hooks
This is directly available in TargetInstrInfo
1 parent 55422e8 commit cf4e8e3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+314
-344
lines changed

‎llvm/include/llvm/CodeGen/TargetInstrInfo.h‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1197,8 +1197,7 @@ class LLVM_ABI TargetInstrInfo : public MCInstrInfo {
11971197
/// register spill instruction, part of prologue, during the frame lowering.
11981198
virtual void storeRegToStackSlot(
11991199
MachineBasicBlock &MBB, MachineBasicBlock::iterator MI, Register SrcReg,
1200-
bool isKill, int FrameIndex, const TargetRegisterClass *RC,
1201-
const TargetRegisterInfo *TRI, Register VReg,
1200+
bool isKill, int FrameIndex, const TargetRegisterClass *RC, Register VReg,
12021201
MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const {
12031202
llvm_unreachable("Target didn't implement "
12041203
"TargetInstrInfo::storeRegToStackSlot!");
@@ -1216,8 +1215,7 @@ class LLVM_ABI TargetInstrInfo : public MCInstrInfo {
12161215
/// register reload instruction, part of epilogue, during the frame lowering.
12171216
virtual void loadRegFromStackSlot(
12181217
MachineBasicBlock &MBB, MachineBasicBlock::iterator MI, Register DestReg,
1219-
int FrameIndex, const TargetRegisterClass *RC,
1220-
const TargetRegisterInfo *TRI, Register VReg,
1218+
int FrameIndex, const TargetRegisterClass *RC, Register VReg,
12211219
MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const {
12221220
llvm_unreachable("Target didn't implement "
12231221
"TargetInstrInfo::loadRegFromStackSlot!");

‎llvm/lib/CodeGen/FixupStatepointCallerSaved.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ class StatepointState {
420420

421421
LLVM_DEBUG(dbgs() << "Insert spill before " << *InsertBefore);
422422
TII.storeRegToStackSlot(*MI.getParent(), InsertBefore, Reg, IsKill, FI,
423-
RC, &TRI, Register());
423+
RC, Register());
424424
}
425425
}
426426

@@ -429,15 +429,15 @@ class StatepointState {
429429
const TargetRegisterClass *RC = TRI.getMinimalPhysRegClass(Reg);
430430
int FI = RegToSlotIdx[Reg];
431431
if (It != MBB->end()) {
432-
TII.loadRegFromStackSlot(*MBB, It, Reg, FI, RC, &TRI, Register());
432+
TII.loadRegFromStackSlot(*MBB, It, Reg, FI, RC, Register());
433433
return;
434434
}
435435

436436
// To insert reload at the end of MBB, insert it before last instruction
437437
// and then swap them.
438438
assert(!MBB->empty() && "Empty block");
439439
--It;
440-
TII.loadRegFromStackSlot(*MBB, It, Reg, FI, RC, &TRI, Register());
440+
TII.loadRegFromStackSlot(*MBB, It, Reg, FI, RC, Register());
441441
MachineInstr *Reload = It->getPrevNode();
442442
int Dummy = 0;
443443
(void)Dummy;

‎llvm/lib/CodeGen/InlineSpiller.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ bool InlineSpiller::hoistSpillInsideBB(LiveInterval &SpillLI,
473473
MachineInstrSpan MIS(MII, MBB);
474474
// Insert spill without kill flag immediately after def.
475475
TII.storeRegToStackSlot(*MBB, MII, SrcReg, false, StackSlot,
476-
MRI.getRegClass(SrcReg), &TRI, Register());
476+
MRI.getRegClass(SrcReg), Register());
477477
LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MII);
478478
for (const MachineInstr &MI : make_range(MIS.begin(), MII))
479479
getVDefInterval(MI, LIS);
@@ -1119,7 +1119,7 @@ void InlineSpiller::insertReload(Register NewVReg,
11191119

11201120
MachineInstrSpan MIS(MI, &MBB);
11211121
TII.loadRegFromStackSlot(MBB, MI, NewVReg, StackSlot,
1122-
MRI.getRegClass(NewVReg), &TRI, Register());
1122+
MRI.getRegClass(NewVReg), Register());
11231123

11241124
LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MI);
11251125

@@ -1155,7 +1155,7 @@ void InlineSpiller::insertSpill(Register NewVReg, bool isKill,
11551155

11561156
if (IsRealSpill)
11571157
TII.storeRegToStackSlot(MBB, SpillBefore, NewVReg, isKill, StackSlot,
1158-
MRI.getRegClass(NewVReg), &TRI, Register());
1158+
MRI.getRegClass(NewVReg), Register());
11591159
else
11601160
// Don't spill undef value.
11611161
// Anything works for undef, in particular keeping the memory
@@ -1729,7 +1729,7 @@ void HoistSpillHelper::hoistAllSpills() {
17291729
MachineBasicBlock::iterator MII = IPA.getLastInsertPointIter(OrigLI, *BB);
17301730
MachineInstrSpan MIS(MII, BB);
17311731
TII.storeRegToStackSlot(*BB, MII, LiveReg, false, Slot,
1732-
MRI.getRegClass(LiveReg), &TRI, Register());
1732+
MRI.getRegClass(LiveReg), Register());
17331733
LIS.InsertMachineInstrRangeInMaps(MIS.begin(), MII);
17341734
for (const MachineInstr &MI : make_range(MIS.begin(), MII))
17351735
getVDefInterval(MI, LIS);

‎llvm/lib/CodeGen/RegAllocFast.cpp‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,7 @@ void RegAllocFastImpl::spill(MachineBasicBlock::iterator Before,
594594
LLVM_DEBUG(dbgs() << " to stack slot #" << FI << '\n');
595595

596596
const TargetRegisterClass &RC = *MRI->getRegClass(VirtReg);
597-
TII->storeRegToStackSlot(*MBB, Before, AssignedReg, Kill, FI, &RC, TRI,
598-
VirtReg);
597+
TII->storeRegToStackSlot(*MBB, Before, AssignedReg, Kill, FI, &RC, VirtReg);
599598
++NumStores;
600599

601600
MachineBasicBlock::iterator FirstTerm = MBB->getFirstTerminator();
@@ -652,7 +651,7 @@ void RegAllocFastImpl::reload(MachineBasicBlock::iterator Before,
652651
<< printReg(PhysReg, TRI) << '\n');
653652
int FI = getStackSpaceFor(VirtReg);
654653
const TargetRegisterClass &RC = *MRI->getRegClass(VirtReg);
655-
TII->loadRegFromStackSlot(*MBB, Before, PhysReg, FI, &RC, TRI, VirtReg);
654+
TII->loadRegFromStackSlot(*MBB, Before, PhysReg, FI, &RC, VirtReg);
656655
++NumLoads;
657656
}
658657

@@ -1123,7 +1122,7 @@ bool RegAllocFastImpl::defineVirtReg(MachineInstr &MI, unsigned OpNum,
11231122
if (MO.isMBB()) {
11241123
MachineBasicBlock *Succ = MO.getMBB();
11251124
TII->storeRegToStackSlot(*Succ, Succ->begin(), PhysReg, Kill, FI,
1126-
&RC, TRI, VirtReg);
1125+
&RC, VirtReg);
11271126
++NumStores;
11281127
Succ->addLiveIn(PhysReg);
11291128
}

‎llvm/lib/CodeGen/RegisterScavenging.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,14 +276,14 @@ RegScavenger::spill(Register Reg, const TargetRegisterClass &RC, int SPAdj,
276276
": Cannot scavenge register without an emergency "
277277
"spill slot!");
278278
}
279-
TII->storeRegToStackSlot(*MBB, Before, Reg, true, FI, &RC, TRI, Register());
279+
TII->storeRegToStackSlot(*MBB, Before, Reg, true, FI, &RC, Register());
280280
MachineBasicBlock::iterator II = std::prev(Before);
281281

282282
unsigned FIOperandNum = getFrameIndexOperandNum(*II);
283283
TRI->eliminateFrameIndex(II, SPAdj, FIOperandNum, this);
284284

285285
// Restore the scavenged register before its use (or first terminator).
286-
TII->loadRegFromStackSlot(*MBB, UseMI, Reg, FI, &RC, TRI, Register());
286+
TII->loadRegFromStackSlot(*MBB, UseMI, Reg, FI, &RC, Register());
287287
II = std::prev(UseMI);
288288

289289
FIOperandNum = getFrameIndexOperandNum(*II);

‎llvm/lib/CodeGen/TargetFrameLoweringImpl.cpp‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ void TargetFrameLowering::spillCalleeSavedRegister(
198198
} else {
199199
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg);
200200
TII->storeRegToStackSlot(SaveBlock, MI, Reg, true, CS.getFrameIdx(), RC,
201-
TRI, Register());
201+
Register());
202202
}
203203
}
204204

@@ -212,8 +212,7 @@ void TargetFrameLowering::restoreCalleeSavedRegister(
212212
.addReg(CS.getDstReg(), getKillRegState(true));
213213
} else {
214214
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg);
215-
TII->loadRegFromStackSlot(MBB, MI, Reg, CS.getFrameIdx(), RC, TRI,
216-
Register());
215+
TII->loadRegFromStackSlot(MBB, MI, Reg, CS.getFrameIdx(), RC, Register());
217216
assert(MI != MBB.begin() && "loadRegFromStackSlot didn't insert any code!");
218217
}
219218
}

‎llvm/lib/CodeGen/TargetInstrInfo.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -794,11 +794,11 @@ MachineInstr *TargetInstrInfo::foldMemoryOperand(MachineInstr &MI,
794794
// code.
795795
BuildMI(*MBB, Pos, MI.getDebugLoc(), get(TargetOpcode::KILL)).add(MO);
796796
} else {
797-
storeRegToStackSlot(*MBB, Pos, MO.getReg(), MO.isKill(), FI, RC, &TRI,
797+
storeRegToStackSlot(*MBB, Pos, MO.getReg(), MO.isKill(), FI, RC,
798798
Register());
799799
}
800800
} else
801-
loadRegFromStackSlot(*MBB, Pos, MO.getReg(), FI, RC, &TRI, Register());
801+
loadRegFromStackSlot(*MBB, Pos, MO.getReg(), FI, RC, Register());
802802

803803
return &*--Pos;
804804
}

‎llvm/lib/Target/AArch64/AArch64InstrInfo.cpp‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5664,7 +5664,6 @@ void AArch64InstrInfo::storeRegToStackSlot(MachineBasicBlock &MBB,
56645664
MachineBasicBlock::iterator MBBI,
56655665
Register SrcReg, bool isKill, int FI,
56665666
const TargetRegisterClass *RC,
5667-
const TargetRegisterInfo *TRI,
56685667
Register VReg,
56695668
MachineInstr::MIFlag Flags) const {
56705669
MachineFunction &MF = *MBB.getParent();
@@ -5678,7 +5677,7 @@ void AArch64InstrInfo::storeRegToStackSlot(MachineBasicBlock &MBB,
56785677
bool Offset = true;
56795678
MCRegister PNRReg = MCRegister::NoRegister;
56805679
unsigned StackID = TargetStackID::Default;
5681-
switch (TRI->getSpillSize(*RC)) {
5680+
switch (RI.getSpillSize(*RC)) {
56825681
case 1:
56835682
if (AArch64::FPR8RegClass.hasSubClassEq(RC))
56845683
Opc = AArch64::STRBui;
@@ -5841,10 +5840,12 @@ static void loadRegPairFromStackSlot(const TargetRegisterInfo &TRI,
58415840
.addMemOperand(MMO);
58425841
}
58435842

5844-
void AArch64InstrInfo::loadRegFromStackSlot(
5845-
MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI, Register DestReg,
5846-
int FI, const TargetRegisterClass *RC, const TargetRegisterInfo *TRI,
5847-
Register VReg, MachineInstr::MIFlag Flags) const {
5843+
void AArch64InstrInfo::loadRegFromStackSlot(MachineBasicBlock &MBB,
5844+
MachineBasicBlock::iterator MBBI,
5845+
Register DestReg, int FI,
5846+
const TargetRegisterClass *RC,
5847+
Register VReg,
5848+
MachineInstr::MIFlag Flags) const {
58485849
MachineFunction &MF = *MBB.getParent();
58495850
MachineFrameInfo &MFI = MF.getFrameInfo();
58505851
MachinePointerInfo PtrInfo = MachinePointerInfo::getFixedStack(MF, FI);
@@ -5856,7 +5857,7 @@ void AArch64InstrInfo::loadRegFromStackSlot(
58565857
bool Offset = true;
58575858
unsigned StackID = TargetStackID::Default;
58585859
Register PNRReg = MCRegister::NoRegister;
5859-
switch (TRI->getSpillSize(*RC)) {
5860+
switch (TRI.getSpillSize(*RC)) {
58605861
case 1:
58615862
if (AArch64::FPR8RegClass.hasSubClassEq(RC))
58625863
Opc = AArch64::LDRBui;
@@ -6492,10 +6493,10 @@ MachineInstr *AArch64InstrInfo::foldMemoryOperandImpl(
64926493
"Mismatched register size in non subreg COPY");
64936494
if (IsSpill)
64946495
storeRegToStackSlot(MBB, InsertPt, SrcReg, SrcMO.isKill(), FrameIndex,
6495-
getRegClass(SrcReg), &TRI, Register());
6496+
getRegClass(SrcReg), Register());
64966497
else
64976498
loadRegFromStackSlot(MBB, InsertPt, DstReg, FrameIndex,
6498-
getRegClass(DstReg), &TRI, Register());
6499+
getRegClass(DstReg), Register());
64996500
return &*--InsertPt;
65006501
}
65016502

@@ -6513,8 +6514,7 @@ MachineInstr *AArch64InstrInfo::foldMemoryOperandImpl(
65136514
assert(SrcMO.getSubReg() == 0 &&
65146515
"Unexpected subreg on physical register");
65156516
storeRegToStackSlot(MBB, InsertPt, AArch64::XZR, SrcMO.isKill(),
6516-
FrameIndex, &AArch64::GPR64RegClass, &TRI,
6517-
Register());
6517+
FrameIndex, &AArch64::GPR64RegClass, Register());
65186518
return &*--InsertPt;
65196519
}
65206520

@@ -6548,7 +6548,7 @@ MachineInstr *AArch64InstrInfo::foldMemoryOperandImpl(
65486548
assert(TRI.getRegSizeInBits(*getRegClass(SrcReg)) ==
65496549
TRI.getRegSizeInBits(*FillRC) &&
65506550
"Mismatched regclass size on folded subreg COPY");
6551-
loadRegFromStackSlot(MBB, InsertPt, DstReg, FrameIndex, FillRC, &TRI,
6551+
loadRegFromStackSlot(MBB, InsertPt, DstReg, FrameIndex, FillRC,
65526552
Register());
65536553
MachineInstr &LoadMI = *--InsertPt;
65546554
MachineOperand &LoadDst = LoadMI.getOperand(0);

‎llvm/lib/Target/AArch64/AArch64InstrInfo.h‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,14 +353,13 @@ class AArch64InstrInfo final : public AArch64GenInstrInfo {
353353

354354
void storeRegToStackSlot(
355355
MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI, Register SrcReg,
356-
bool isKill, int FrameIndex, const TargetRegisterClass *RC,
357-
const TargetRegisterInfo *TRI, Register VReg,
356+
bool isKill, int FrameIndex, const TargetRegisterClass *RC, Register VReg,
358357
MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const override;
359358

360359
void loadRegFromStackSlot(
361360
MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
362361
Register DestReg, int FrameIndex, const TargetRegisterClass *RC,
363-
const TargetRegisterInfo *TRI, Register VReg,
362+
Register VReg,
364363
MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const override;
365364

366365
// This tells target independent code that it is okay to pass instructions

‎llvm/lib/Target/AMDGPU/SIInstrInfo.cpp‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1668,8 +1668,7 @@ unsigned SIInstrInfo::getVectorRegSpillSaveOpcode(
16681668

16691669
void SIInstrInfo::storeRegToStackSlot(
16701670
MachineBasicBlock &MBB, MachineBasicBlock::iterator MI, Register SrcReg,
1671-
bool isKill, int FrameIndex, const TargetRegisterClass *RC,
1672-
const TargetRegisterInfo *TRI, Register VReg,
1671+
bool isKill, int FrameIndex, const TargetRegisterClass *RC, Register VReg,
16731672
MachineInstr::MIFlag Flags) const {
16741673
MachineFunction *MF = MBB.getParent();
16751674
SIMachineFunctionInfo *MFI = MF->getInfo<SIMachineFunctionInfo>();
@@ -1681,7 +1680,7 @@ void SIInstrInfo::storeRegToStackSlot(
16811680
MachineMemOperand *MMO = MF->getMachineMemOperand(
16821681
PtrInfo, MachineMemOperand::MOStore, FrameInfo.getObjectSize(FrameIndex),
16831682
FrameInfo.getObjectAlign(FrameIndex));
1684-
unsigned SpillSize = TRI->getSpillSize(*RC);
1683+
unsigned SpillSize = RI.getSpillSize(*RC);
16851684

16861685
MachineRegisterInfo &MRI = MF->getRegInfo();
16871686
if (RI.isSGPRClass(RC)) {
@@ -1863,14 +1862,13 @@ void SIInstrInfo::loadRegFromStackSlot(MachineBasicBlock &MBB,
18631862
MachineBasicBlock::iterator MI,
18641863
Register DestReg, int FrameIndex,
18651864
const TargetRegisterClass *RC,
1866-
const TargetRegisterInfo *TRI,
18671865
Register VReg,
18681866
MachineInstr::MIFlag Flags) const {
18691867
MachineFunction *MF = MBB.getParent();
18701868
SIMachineFunctionInfo *MFI = MF->getInfo<SIMachineFunctionInfo>();
18711869
MachineFrameInfo &FrameInfo = MF->getFrameInfo();
18721870
const DebugLoc &DL = MBB.findDebugLoc(MI);
1873-
unsigned SpillSize = TRI->getSpillSize(*RC);
1871+
unsigned SpillSize = RI.getSpillSize(*RC);
18741872

18751873
MachinePointerInfo PtrInfo
18761874
= MachinePointerInfo::getFixedStack(*MF, FrameIndex);

0 commit comments

Comments
 (0)