Review comments, fix Windows test

Author: krzysz00

mlir/docs/DeclarativeRewrites.md

@@ -433,7 +433,8 @@ $in2)`, then this will be translated into C++ call `someFn($in1, $in2, $in0)`.
 In the case of properties, the placeholder will be bound to a value of the _interface_
 type of the property. Passing in a `StringProp` as an argument to a `NativeCodeCall`
 will pass a `StringRef` (as if the getter of the matched operation were called)
-and not a `std::string`.
+and not a `std::string`. See `mlir/include/mlir/IR/Properties.td` for details
+on interface vs. storage type.
 
 Positional range placeholders will be substituted by multiple `dag` object
 parameters at the `NativeCodeCall` use site. For example, if we define

mlir/include/mlir/TableGen/Pattern.h

@@ -99,7 +99,8 @@ class DagLeaf {
   // Returns this DAG leaf as a constraint. Asserts if fails.
   Constraint getAsConstraint() const;
 
-  // Returns this DAG leaf as a property constraint. Asserts if fails.
+  // Returns this DAG leaf as a property constraint. Asserts if fails. This
+  // allows access to the interface type.
   PropConstraint getAsPropConstraint() const;
 
   // Returns this DAG leaf as a property definition. Asserts if fails.
@@ -301,9 +302,8 @@ class SymbolInfoMap {
     //
     // * Properties not associated with an operation (ex. as arguments to
     //   native code) have their corresponding PropConstraint stored in the
-    //   `dag` field,
-    //  and set `operandIndexOrNumValues` to -1 to indicate they aren't part of
-    //  an operation.
+    //   `dag` field. (They'll and set `operandIndexOrNumValues` to -1 to
+    //   indicate they aren't part of an operation.)
     //
     // * If a symbol is defined in a `variadic` DAG, `dag` specifies the DAG
     //   of the parent operation, `operandIndexOrNumValues` specifies the

mlir/test/mlir-tblgen/rewriter-static-matcher.td

@@ -94,10 +94,10 @@ def : Pat<(COp $_, (BOp I32Attr:$attr, I32:$int)),
 // CHECK: [[$ARR]].push_back([[$VAR]]);
 def : Pat<(AOp $x), (DOp (variadic (Foo $x)))>;
 
-// CHECK: if(::mlir::failed([[$DAG_MATCHER2]](rewriter, op1, tblgen_ops, z, x)
+// CHECK: if(::mlir::failed([[$DAG_MATCHER2]]({{.*}} x{{[,)]}}
 def : Pat<(AOp (EOp NonNegProp:$x, NonNegProp:$_, I32:$z)),
   (AOp $z)>;
 
-// CHECK: if(::mlir::failed([[$DAG_MATCHER2]](rewriter, op1, tblgen_ops, z, x)
+// CHECK: if(::mlir::failed([[$DAG_MATCHER2]]({{.*}} x{{[,)]}}
 def : Pat<(FOp $_, (EOp NonNegProp:$x, NonNegProp:$_, I32:$z)),
   (COp $x, $z)>;