Fix compat with vector<?xi1>

Author: ianayl

mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp

@@ -619,12 +619,11 @@ struct IndexCastIndexI1Pattern final
   LogicalResult
   matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
-    Type srcType = adaptor.getIn().getType();
-    if (!op.getType().isInteger(1))
+    if (!isBoolScalarOrVector(op.getType()))
       return failure();
 
     Location loc = op.getLoc();
-    Value zeroIdx = spirv::ConstantOp::getZero(srcType, loc, rewriter);
+    Value zeroIdx = spirv::ConstantOp::getZero(adaptor.getIn().getType(), loc, rewriter);
     rewriter.replaceOpWithNewOp<spirv::INotEqualOp>(op, op.getType(), zeroIdx,
                                                     adaptor.getIn());
     return success();

mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir

@@ -734,14 +734,22 @@ func.func @index_castui4(%arg0: index) {
   return
 }
 
-// CHECK-LABEL: index_castindexi1
-func.func @index_castindexi1(%arg0 : index) {
+// CHECK-LABEL: index_castindexi1_1
+func.func @index_castindexi1_1(%arg0 : index) {
   // CHECK: %[[ZERO:.+]] = spirv.Constant 0 : i32
   // CHECK: spirv.INotEqual %[[ZERO]], %{{.+}} : i32
   %0 = arith.index_cast %arg0 : index to i1
   return
 }
 
+// CHECK-LABEL: index_castindexi1_2
+func.func @index_castindexi1_2(%arg0 : vector<3xindex>) {
+  // CHECK: %[[ZERO:.+]] = spirv.Constant dense<0> : vector<3xi32>
+  // CHECK: spirv.INotEqual %[[ZERO]], %{{.+}} : vector<3xi32>
+  %0 = arith.index_cast %arg0 : vector<3xindex> to vector<3xi1>
+  return
+}
+
 // CHECK-LABEL: @bit_cast
 func.func @bit_cast(%arg0: vector<2xf32>, %arg1: i64) {
   // CHECK: spirv.Bitcast %{{.+}} : vector<2xf32> to vector<2xi32>