Skip to content

Commit cf8ae75

Browse files
committed
[libc++] run clang-tidy on src/ in the CI
1 parent 1ead155 commit cf8ae75

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

libcxx/src/.clang-tidy

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
InheritParentConfig: true
22

33
Checks: >
4-
-readability-identifier-naming
4+
-clang-analyzer-*,
5+
6+
-llvm-include-order,
7+
8+
-modernize-loop-convert,
9+
-modernize-use-equals-delete,
10+
-modernize-use-nullptr,
11+
-modernize-use-override,
12+
13+
-readability-identifier-naming,
14+
-readability-function-cognitive-complexity,
15+
-readability-function-size,
16+
-readability-simplify-boolean-expr,
17+
18+
# TODO: Consider enabling clang-analyzer. Without the checks clang-tidy runs 18x faster on my system.

libcxx/utils/ci/run-buildbot

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ function generate-cmake() {
144144
generate-cmake-base \
145145
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \
146146
-DLIBCXX_CXX_ABI=libcxxabi \
147+
-DCMAKE_EXPORT_COMPILE_COMMANDS=On \
147148
"${@}"
148149
}
149150

@@ -328,6 +329,8 @@ generic-cxx26)
328329
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-cxx26.cmake"
329330
check-runtimes
330331
check-abi-list
332+
python3 $MONOREPO_ROOT/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py \
333+
-clang-tidy-binary clang-tidy-20 -warnings-as-errors \* -source-filter ".*libcxx/src.*" -p "${BUILD_DIR}"
331334
;;
332335
#
333336
# Other compiler support

0 commit comments

Comments
 (0)