simplify translation

Author: bcardosolopes

mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp

@@ -16,6 +16,7 @@
 #include "mlir/Support/LLVM.h"
 #include "mlir/Target/LLVMIR/ModuleTranslation.h"
 
+#include "llvm/ADT/TypeSwitch.h"
 #include "llvm/IR/IRBuilder.h"
 #include "llvm/IR/InlineAsm.h"
 #include "llvm/IR/MDBuilder.h"
@@ -274,16 +275,23 @@ static void convertModuleFlagsOp(ArrayAttr flags, llvm::IRBuilderBase &builder,
                                  LLVM::ModuleTranslation &moduleTranslation) {
   llvm::Module *llvmModule = moduleTranslation.getLLVMModule();
   for (auto flagAttr : flags.getAsRange<ModuleFlagAttr>()) {
-    if (auto intAttr = dyn_cast<mlir::IntegerAttr>(flagAttr.getValue()))
-      llvmModule->addModuleFlag(
-          convertModFlagBehaviorToLLVM(flagAttr.getBehavior()),
-          flagAttr.getKey().getValue(), intAttr.getUInt());
-    else if (auto strAttr = dyn_cast<mlir::StringAttr>(flagAttr.getValue())) {
-      llvmModule->addModuleFlag(
-          convertModFlagBehaviorToLLVM(flagAttr.getBehavior()),
-          flagAttr.getKey().getValue(),
-          llvm::MDString::get(builder.getContext(), strAttr.getValue()));
-    }
+    llvm::Metadata *valueMetadata =
+        llvm::TypeSwitch<Attribute, llvm::Metadata *>(flagAttr.getValue())
+            .Case<StringAttr>([&](auto strAttr) {
+              return llvm::MDString::get(builder.getContext(),
+                                         strAttr.getValue());
+            })
+            .Case<IntegerAttr>([&](auto intAttr) {
+              return llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
+                  llvm::Type::getInt32Ty(builder.getContext()),
+                  intAttr.getInt()));
+            })
+            .Default([](auto) { return nullptr; });
+
+    assert(metadata && "expected valid metadata");
+    llvmModule->addModuleFlag(
+        convertModFlagBehaviorToLLVM(flagAttr.getBehavior()),
+        flagAttr.getKey().getValue(), valueMetadata);
   }
 }