Skip to content

Commit cff1850

Browse files
committed
Address review feedback
1 parent adea12f commit cff1850

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lldb/tools/lldb-dap/src-ts/lldb-dap-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class LLDBDapServer implements vscode.Disposable {
2626
args: string[],
2727
options?: child_process.SpawnOptionsWithoutStdio,
2828
): Promise<{ host: string; port: number } | undefined> {
29-
const dapArgs = [...args, "--connection", "connect://localhost:0"];
29+
const dapArgs = [...args, "--connection", "listen://localhost:0" ];
3030
if (!(await this.shouldContinueStartup(dapPath, dapArgs))) {
3131
return undefined;
3232
}

lldb/tools/lldb-dap/tool/lldb-dap.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ static void PrintHelp(LLDBDAPOptTable &table, llvm::StringRef tool_name) {
127127
parent over stdio. Passing a --connection URI will cause lldb-dap to listen
128128
for a connection in the specified mode.
129129
130-
lldb-dap --connection connection://localhost:<port>
130+
lldb-dap --connection listen://localhost:<port>
131131
132132
Passing --wait-for-debugger will pause the process at startup and wait for a
133133
debugger to attach to the process.
@@ -228,7 +228,7 @@ validateConnection(llvm::StringRef conn) {
228228

229229
auto make_error = [conn]() -> llvm::Error {
230230
return llvm::createStringError(
231-
"Unsupported connection specifier, expected 'accept://path' or "
231+
"Unsupported connection specifier, expected 'accept:///path' or "
232232
"'listen://[host]:port', got '%s'.",
233233
conn.str().c_str());
234234
};

0 commit comments

Comments
 (0)