Skip to content

Commit d04eec0

Browse files
committed
fixup! address review comments
1 parent 07181b4 commit d04eec0

File tree

2 files changed

+5
-24
lines changed

2 files changed

+5
-24
lines changed

llvm/lib/TargetParser/RISCVISAInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ Error RISCVISAInfo::checkDependency() {
748748
{"xqcicm"}, {"xqcics"}, {"xqcicsr"}, {"xqciint"},
749749
{"xqcilia"}, {"xqcilo"}, {"xqcilsm"}, {"xqcisls"}};
750750
static constexpr StringLiteral ZcdOverlaps[] = {
751-
{"zcmt"}, {"zcmp"}, {"xqciac"}, {"xqcicm"}};
751+
{"zcmt"}, {"zcmp"}, {"xqccmp"}, {"xqciac"}, {"xqcicm"}};
752752

753753
if (HasI && HasE)
754754
return getIncompatibleError("i", "e");

llvm/unittests/TargetParser/RISCVISAInfoTest.cpp

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -663,30 +663,11 @@ TEST(ParseArchString, RejectsConflictingExtensions) {
663663
::testing::EndsWith(" is only supported for 'rv32'"));
664664
}
665665

666-
for (StringRef Input : {"rv32idc_xqciac0p3"}) {
667-
EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
668-
"'xqciac' extension is incompatible with 'c' extension when 'd' "
669-
"extension is enabled");
670-
}
671-
672-
for (StringRef Input : {"rv32i_zcd_xqciac0p3"}) {
673-
EXPECT_EQ(
674-
toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
675-
"'xqciac' extension is incompatible with 'zcd' extension when 'd' "
676-
"extension is enabled");
677-
}
678-
679-
for (StringRef Input : {"rv32idc_xqcicm0p2"}) {
680-
EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
681-
"'xqcicm' extension is incompatible with 'c' extension when 'd' "
682-
"extension is enabled");
683-
}
684-
685-
for (StringRef Input : {"rv32i_zcd_xqcicm0p2"}) {
686-
EXPECT_EQ(
666+
for (StringRef Input : {"rv32idc_xqciac0p3", "rv32i_zcd_xqciac0p3", "rv32idc_xqcicm0p2",
667+
"rv32i_zcd_xqcicm0p2"}) {
668+
EXPECT_THAT(
687669
toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
688-
"'xqcicm' extension is incompatible with 'zcd' extension when 'd' "
689-
"extension is enabled");
670+
::testing::EndsWith("extension when 'd' extension is enabled"));
690671
}
691672

692673
for (StringRef Input : {"rv32i_zcmp_xqccmp0p1", "rv64i_zcmp_xqccmp0p1"}) {

0 commit comments

Comments
 (0)