removed isPublic function condition

Author: balazske

clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp

@@ -35,7 +35,7 @@ void MisleadingSetterOfReferenceCheck::registerMatchers(MatchFinder *Finder) {
                    anyOf(has(BinaryOpAssign), has(CXXOperatorCallAssign)));
   auto BadSetFunction =
       cxxMethodDecl(
-          parameterCountIs(1), isPublic(),
+          parameterCountIs(1),
           hasParameter(
               0,
               parmVarDecl(hasType(hasCanonicalType(pointerType(pointee(qualType(

clang-tools-extra/docs/clang-tidy/checks/bugprone/misleading-setter-of-reference.rst

@@ -6,7 +6,7 @@ bugprone-misleading-setter-of-reference
 Finds setter-like member functions that take a pointer parameter and set a
 reference member of the same class with the pointed value.
 
-The check detects public member functions that take a single pointer parameter,
+The check detects member functions that take a single pointer parameter,
 and contain a single expression statement that dereferences the parameter and
 assigns the result to a data member with a reference type.
 

clang-tools-extra/test/clang-tidy/checkers/bugprone/misleading-setter-of-reference.cpp

@@ -46,8 +46,9 @@ class Test1 {
     MemLPub = *NewValue;
   }
 
-protected:
+private:
   void set5(long *NewValue) {
+    // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: function 'set5' can be mistakenly used in order to change the reference 'MemL' instead of the value of it
     MemL = *NewValue;
   }
 };