Remove ReadOnly attribute for PR elements

Author: redstar

llvm/include/llvm/MC/MCGOFFAttributes.h

@@ -73,7 +73,6 @@ struct LDAttr {
 // Attributes for PR symbols.
 struct PRAttr {
   bool IsRenamable = false;
-  bool IsReadOnly = false; // ???? Not documented.
   GOFF::ESDExecutable Executable = GOFF::ESD_EXE_Unspecified;
   GOFF::ESDLinkageType Linkage = GOFF::ESD_LT_XPLink;
   GOFF::ESDBindingScope BindingScope = GOFF::ESD_BSC_Unspecified;

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

@@ -2820,7 +2820,7 @@ MCSection *TargetLoweringObjectFileGOFF::getSectionForLSDA(
       static_cast<MCSectionGOFF *>(TextSection)->getParent());
   return getContext().getGOFFSection(
       SectionKind::getData(), Name,
-      GOFF::PRAttr{true, false, GOFF::ESD_EXE_DATA, GOFF::LINKAGE,
+      GOFF::PRAttr{true, GOFF::ESD_EXE_DATA, GOFF::LINKAGE,
                    GOFF::ESD_BSC_Section, GOFF::ESD_ALIGN_Fullword, 0},
       WSA);
 }
@@ -2850,11 +2850,11 @@ MCSection *TargetLoweringObjectFileGOFF::SelectSectionForGlobal(
                      GOFF::ESD_TS_ByteOriented, GOFF::ESD_BA_Merge,
                      GOFF::ESD_LB_Deferred, GOFF::ESD_RQ_0, Align},
         SD);
-    return getContext().getGOFFSection(
-        Kind, Symbol->getName(),
-        GOFF::PRAttr{false, false, GOFF::ESD_EXE_DATA, GOFF::LINKAGE,
-                     PRBindingScope, Align, 0},
-        ED);
+    return getContext().getGOFFSection(Kind, Symbol->getName(),
+                                       GOFF::PRAttr{false, GOFF::ESD_EXE_DATA,
+                                                    GOFF::LINKAGE,
+                                                    PRBindingScope, Align, 0},
+                                       ED);
   }
   return TextSection;
 }

llvm/lib/MC/GOFFObjectWriter.cpp

@@ -266,7 +266,6 @@ class GOFFSymbol {
     BehavAttrs.setAlignment(Attr.Alignment);
     BehavAttrs.setLinkageType(Attr.Linkage);
     BehavAttrs.setBindingScope(Attr.BindingScope);
-    BehavAttrs.setReadOnly(Attr.IsReadOnly);
   }
 };
 

llvm/lib/MC/MCObjectFileInfo.cpp

@@ -560,7 +560,7 @@ void MCObjectFileInfo::initGOFFMCObjectFileInfo(const Triple &T) {
       RootSDSection);
   ADASection = Ctx->getGOFFSection(
       SectionKind::getData(), "#S",
-      GOFF::PRAttr{false, false, GOFF::ESD_EXE_DATA, GOFF::ESD_LT_XPLink,
+      GOFF::PRAttr{false, GOFF::ESD_EXE_DATA, GOFF::ESD_LT_XPLink,
                    GOFF::ESD_BSC_Section, GOFF::ESD_ALIGN_Quadword, 0},
       ADAEDSection);
 
@@ -581,7 +581,7 @@ void MCObjectFileInfo::initGOFFMCObjectFileInfo(const Triple &T) {
       RootSDSection);
   PPA2ListSection = Ctx->getGOFFSection(
       SectionKind::getData(), ".&ppa2",
-      GOFF::PRAttr{true, false, GOFF::ESD_EXE_DATA, GOFF::ESD_LT_OS,
+      GOFF::PRAttr{true, GOFF::ESD_EXE_DATA, GOFF::ESD_LT_OS,
                    GOFF::ESD_BSC_Section, GOFF::ESD_ALIGN_Doubleword, 0},
       PPA2ListEDSection);
 

llvm/lib/MC/MCSectionGOFF.cpp

@@ -124,7 +124,7 @@ void MCSectionGOFF::printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
     if (!Emitted) {
       emitCATTR(OS, ED->getName(), ED->getEDAttributes().Rmode,
                 PRAttributes.Alignment, ED->EDAttributes.LoadBehavior,
-                PRAttributes.Executable, PRAttributes.IsReadOnly,
+                PRAttributes.Executable, ED->EDAttributes.IsReadOnly,
                 PRAttributes.SortKey, Name);
       emitXATTR(OS, Name, PRAttributes.Linkage, PRAttributes.Executable,
                 PRAttributes.BindingScope);