add basic float range validations

Author: inbelic

clang/lib/Sema/SemaHLSL.cpp

@@ -1093,6 +1093,14 @@ bool SemaHLSL::handleRootSignatureElements(
         << LowerBound << UpperBound;
   };
 
+  auto ReportFloatError = [this, &HadError](SourceLocation Loc,
+                                            float LowerBound,
+                                            float UpperBound) {
+    HadError = true;
+    this->Diag(Loc, diag::err_hlsl_invalid_rootsig_value)
+        << std::to_string(LowerBound) << std::to_string(UpperBound);
+  };
+
   auto VerifyRegister = [ReportError](SourceLocation Loc, uint32_t Register) {
     if (!llvm::hlsl::rootsig::verifyRegisterValue(Register))
       ReportError(Loc, 0, 0xfffffffe);
@@ -1126,6 +1134,8 @@ bool SemaHLSL::handleRootSignatureElements(
 
       if (16 < Sampler->MaxAnisotropy)
         ReportError(Loc, 0, 16);
+      if (!llvm::hlsl::rootsig::verifyMipLODBias(Sampler->MipLODBias))
+        ReportFloatError(Loc, -16.f, 15.99);
     } else if (const auto *Clause =
                    std::get_if<llvm::hlsl::rootsig::DescriptorTableClause>(
                        &Elem)) {

clang/test/SemaHLSL/RootSignature-err.hlsl

@@ -66,6 +66,11 @@ void basic_validation_3() {}
 [RootSignature("DescriptorTable(UAV(u0, numDescriptors = 0), Sampler(s0, numDescriptors = 0))")]
 void basic_validation_4() {}
 
-// expected-error@+1 {{value must be in the range [0, 16]}}
+// expected-error@+2 {{value must be in the range [0, 16]}}
+// expected-error@+1 {{value must be in the range [-16.000000, 15.990000]}}
 [RootSignature("StaticSampler(s0, maxAnisotropy = 17, mipLODBias = -16.000001)")]
 void basic_validation_5() {}
+
+// expected-error@+1 {{value must be in the range [-16.000000, 15.990000]}}
+[RootSignature("StaticSampler(s0, mipLODBias = 15.990001)")]
+void basic_validation_6() {}