Skip to content

Commit d1bf457

Browse files
committed
Addressed review comments
The LLVM comments needs to be proper prose. Updated the comments.
1 parent ed8c9c9 commit d1bf457

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

llvm/unittests/IR/IntrinsicsTest.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ TEST(IntrinsicAttributes, TestGetFnAttributesBug) {
198198
EXPECT_FALSE(AS.hasAttributes());
199199
}
200200

201-
// Test non-overloaded intrinsic
201+
// Tests non-overloaded intrinsic declaration.
202202
TEST_F(IntrinsicsTest, NonOverloadedIntrinsic) {
203203
Type *RetTy = Type::getVoidTy(Context);
204204
SmallVector<Type *, 1> ArgTys;
@@ -215,7 +215,7 @@ TEST_F(IntrinsicsTest, NonOverloadedIntrinsic) {
215215
EXPECT_EQ(F->getName(), "llvm.assume");
216216
}
217217

218-
// Test overloaded intrinsic with automatic type resolution (scalar)
218+
// Tests overloaded intrinsic with automatic type resolution for scalar types.
219219
TEST_F(IntrinsicsTest, OverloadedIntrinsicScalar) {
220220
Type *RetTy = Type::getInt32Ty(Context);
221221
SmallVector<Type *, 2> ArgTys;
@@ -233,7 +233,7 @@ TEST_F(IntrinsicsTest, OverloadedIntrinsicScalar) {
233233
EXPECT_EQ(F->getName(), "llvm.umax.i32");
234234
}
235235

236-
// Test overloaded intrinsic with automatic type resolution (vector)
236+
// Tests overloaded intrinsic with automatic type resolution for vector types.
237237
TEST_F(IntrinsicsTest, OverloadedIntrinsicVector) {
238238
Type *RetTy = FixedVectorType::get(Type::getInt32Ty(Context), 4);
239239
SmallVector<Type *, 2> ArgTys;
@@ -251,7 +251,7 @@ TEST_F(IntrinsicsTest, OverloadedIntrinsicVector) {
251251
EXPECT_EQ(F->getName(), "llvm.umax.v4i32");
252252
}
253253

254-
// Test vararg intrinsic: experimental_gc_statepoint
254+
// Tests vararg intrinsic declaration.
255255
TEST_F(IntrinsicsTest, VarArgIntrinsicStatepoint) {
256256
Type *RetTy = Type::getTokenTy(Context);
257257
SmallVector<Type *, 5> ArgTys;
@@ -272,7 +272,7 @@ TEST_F(IntrinsicsTest, VarArgIntrinsicStatepoint) {
272272
EXPECT_EQ(F->getName(), "llvm.experimental.gc.statepoint.p0");
273273
}
274274

275-
// Test different overloads create different declarations
275+
// Tests that different overloads create different declarations.
276276
TEST_F(IntrinsicsTest, DifferentOverloads) {
277277
// i32 version
278278
Type *RetTy32 = Type::getInt32Ty(Context);
@@ -297,7 +297,7 @@ TEST_F(IntrinsicsTest, DifferentOverloads) {
297297
EXPECT_EQ(F64->getName(), "llvm.umax.i64");
298298
}
299299

300-
// Test IRBuilder::CreateIntrinsic with overloaded scalar type
300+
// Tests IRBuilder::CreateIntrinsic with overloaded scalar type.
301301
TEST_F(IntrinsicsTest, IRBuilderCreateIntrinsicScalar) {
302302
IRBuilder<> Builder(BB);
303303

@@ -315,7 +315,7 @@ TEST_F(IntrinsicsTest, IRBuilderCreateIntrinsicScalar) {
315315
EXPECT_FALSE(CI->getCalledFunction()->isVarArg());
316316
}
317317

318-
// Test IRBuilder::CreateIntrinsic with vector intrinsic
318+
// Tests IRBuilder::CreateIntrinsic with overloaded vector type.
319319
TEST_F(IntrinsicsTest, IRBuilderCreateIntrinsicVector) {
320320
IRBuilder<> Builder(BB);
321321

@@ -333,7 +333,7 @@ TEST_F(IntrinsicsTest, IRBuilderCreateIntrinsicVector) {
333333
EXPECT_FALSE(CI->getCalledFunction()->isVarArg());
334334
}
335335

336-
// Test IRBuilder::CreateIntrinsic with vararg intrinsic
336+
// Tests IRBuilder::CreateIntrinsic with vararg intrinsic.
337337
TEST_F(IntrinsicsTest, IRBuilderCreateIntrinsicVarArg) {
338338
IRBuilder<> Builder(BB);
339339

0 commit comments

Comments
 (0)