Skip to content

Commit d235f85

Browse files
committed
Remove some debugging logic in the test
1 parent b43a7e9 commit d235f85

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

clang/lib/CodeGen/CGPointerAuth.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -520,13 +520,12 @@ void CodeGenFunction::EmitSingleObjectPointerAuthRelocationFixup(
520520
const FixupVectorTy &Fixups, QualType ElementType, Address Dst,
521521
Address Src) {
522522
auto GetFixupAddress = [&](Address BaseAddress, CharUnits Offset,
523-
KnownNonNull_t IsKnownNonNull,
524-
const char *Reason) {
523+
KnownNonNull_t IsKnownNonNull) {
525524
llvm::Value *BasePtr = BaseAddress.emitRawPointer(*this);
526525
llvm::Value *OffsetValue =
527526
llvm::ConstantInt::get(PtrDiffTy, Offset.getQuantity());
528527
llvm::Value *FixupAddress =
529-
Builder.CreateInBoundsGEP(Int8Ty, BasePtr, OffsetValue, Reason);
528+
Builder.CreateInBoundsGEP(Int8Ty, BasePtr, OffsetValue);
530529
return Address(FixupAddress, VoidPtrPtrTy,
531530
BaseAddress.getAlignment().alignmentAtOffset(Offset),
532531
IsKnownNonNull);
@@ -542,12 +541,10 @@ void CodeGenFunction::EmitSingleObjectPointerAuthRelocationFixup(
542541

543542
// We don't use the existing copy helpers as we'll be resigning a
544543
// value in place assuming the old address for the read.
545-
Address FixupDst = GetFixupAddress(Dst, Fixup.Offset, IsKnownNonNull,
546-
"fixup.dst.with.offset");
544+
Address FixupDst = GetFixupAddress(Dst, Fixup.Offset, IsKnownNonNull);
547545
CGPointerAuthInfo DstPtrAuth = EmitPointerAuthInfo(Qualifier, FixupDst);
548546

549-
Address FixupSrc = GetFixupAddress(Src, Fixup.Offset, IsKnownNonNull,
550-
"fixup.src.with.offset");
547+
Address FixupSrc = GetFixupAddress(Src, Fixup.Offset, IsKnownNonNull);
551548
CGPointerAuthInfo SrcPtrAuth = EmitPointerAuthInfo(Qualifier, FixupSrc);
552549

553550
// We're loading from the destination here as we've already performed the

clang/test/CodeGenCXX/cxx2c-trivially-relocatable-ptrauth.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,7 @@
22

33
typedef __SIZE_TYPE__ size_t;
44

5-
6-
#if 1
75
#define vtable_ptrauth(...) [[clang::ptrauth_vtable_pointer(__VA_ARGS__)]]
8-
9-
#else
10-
#define vtable_ptrauth(...)
11-
#define __ptrauth(...)
12-
#endif
13-
146
#define ADDR_AND_TYPE_DISC vtable_ptrauth(process_independent, address_discrimination, type_discrimination)
157
#define TYPE_DISC_ONLY vtable_ptrauth(process_independent, no_address_discrimination, type_discrimination)
168

0 commit comments

Comments
 (0)