Skip to content

Commit d2392bb

Browse files
committed
improve comment
1 parent 9fe4199 commit d2392bb

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

clang/lib/CodeGen/CGExpr.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5981,13 +5981,13 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const BinaryOperator *E) {
59815981

59825982
assert(E->getOpcode() == BO_Assign && "unexpected binary l-value");
59835983

5984-
// This covers both LHS and RHS expressions, though nested RHS
5985-
// expressions may get subsequently separately grouped.
5986-
// FIXME(OCH): Not clear yet if we've got fine enough control
5987-
// to pick and choose when we need to. Currently looks ok:
5988-
// a = b = c -> Two atoms.
5989-
// x = new(1) -> One atom (for both addr store and value store).
5990-
// Complex and agg assignment -> One atom.
5984+
// Create a Key Instructions source location atom group that covers both
5985+
// LHS and RHS expressions. Nested RHS expressions may get subsequently
5986+
// separately grouped (1 below):
5987+
//
5988+
// 1. `a = b = c` -> Two atoms.
5989+
// 2. `x = new(1)` -> One atom (for both addr store and value store).
5990+
// 3. Complex and agg assignment -> One atom.
59915991
ApplyAtomGroup Grp(getDebugInfo());
59925992

59935993
// Note that in all of these cases, __block variables need the RHS

0 commit comments

Comments
 (0)