don't generate summary format argument if not needed

isuckatcs · isuckatcs · commit d3923cedc2f3 · 2025-07-04T18:41:01.000+02:00
diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp
@@ -2985,7 +2985,8 @@ static void GenerateFrontendArgs(const FrontendOptions &Opts,
                 Lang + HeaderUnit + Header + ModuleMap + Preprocessed);
   }
 
-  GenerateArg(Consumer, OPT_summary_format_EQ, Opts.SummaryFormat);
+  if (!Opts.EmitSummaryDir.empty() || !Opts.ReadSummaryDir.empty())
+    GenerateArg(Consumer, OPT_summary_format_EQ, Opts.SummaryFormat);
 
   // OPT_INPUT has a unique class, generate it directly.
   for (const auto &Input : Opts.Inputs)

Original file line number	Diff line number	Diff line change
`@@ -2985,7 +2985,8 @@ static void GenerateFrontendArgs(const FrontendOptions &Opts,`
`2985`	`2985`	`Lang + HeaderUnit + Header + ModuleMap + Preprocessed);`
`2986`	`2986`	`}`
`2987`	`2987`
`2988`		`- GenerateArg(Consumer, OPT_summary_format_EQ, Opts.SummaryFormat);`
	`2988`	`+ if (!Opts.EmitSummaryDir.empty() \|\| !Opts.ReadSummaryDir.empty())`
	`2989`	`+ GenerateArg(Consumer, OPT_summary_format_EQ, Opts.SummaryFormat);`
`2989`	`2990`
`2990`	`2991`	`// OPT_INPUT has a unique class, generate it directly.`
`2991`	`2992`	`for (const auto &Input : Opts.Inputs)`