Skip to content

Commit d3c014f

Browse files
committed
Clarify some comments in test_post_increment
1 parent d9d0033 commit d3c014f

File tree

1 file changed

+6
-4
lines changed
  • libcxx/test/std/ranges/range.adaptors/range.join.with/range.join.with.iterator

1 file changed

+6
-4
lines changed

libcxx/test/std/ranges/range.adaptors/range.join.with/range.join.with.iterator/increment.pass.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ constexpr void test_pre_increment() {
247247
}
248248

249249
constexpr void test_post_increment() {
250-
{ // `V` and `Pattern` are not empty. Test return type too.
250+
{ // `V` and `Pattern` are not empty. Return type should be `iterator`.
251251
using V = std::array<std::array<int, 3>, 2>;
252252
using Pattern = std::array<int, 1>;
253253
using JWV = std::ranges::join_with_view<std::ranges::owning_view<V>, std::ranges::owning_view<Pattern>>;
@@ -296,7 +296,7 @@ constexpr void test_post_increment() {
296296
}
297297
}
298298

299-
{ // `Pattern` is empty, `V` is not. `ref-is-glvalue` is false.
299+
{ // `Pattern` is empty, `V` is not. Value of `ref-is-glvalue` is false (return type should be `void`).
300300
using Inner = std::vector<int>;
301301
using V = RvalueVector<Inner>;
302302
using Pattern = std::ranges::empty_view<int>;
@@ -315,7 +315,8 @@ constexpr void test_post_increment() {
315315
static_assert(std::is_void_v<decltype(it++)>);
316316
}
317317

318-
{ // `V` has empty subrange in the middle, `Pattern` is not empty. OuterIter does not model forward iterator.
318+
{ // `V` has empty subrange in the middle, `Pattern` is not empty.
319+
// OuterIter does not model forward iterator (return type should be `void`).
319320
using Inner = std::vector<int>;
320321
using V = BasicVectorView<Inner, ViewProperties{.common = false}, cpp20_input_iterator>;
321322
using Pattern = std::ranges::single_view<int>;
@@ -337,7 +338,8 @@ constexpr void test_post_increment() {
337338
}
338339

339340
#if !defined(TEST_COMPILER_GCC) // GCC c++/101777
340-
{ // Only first element of `V` is not empty. `Pattern` is empty. InnerIter does not model forward iterator.
341+
{ // Only first element of `V` is not empty. `Pattern` is empty. InnerIter does not model forward
342+
// iterator (return type should be `void`).
341343
using Inner = BasicVectorView<char32_t, ViewProperties{.common = false}, cpp17_input_iterator>;
342344
using V = std::array<Inner, 3>;
343345
using Pattern = std::ranges::empty_view<char32_t>;

0 commit comments

Comments
 (0)