Change signature of emitStoreThroughBitfieldLValue

Author: mmha

clang/lib/CIR/CodeGen/CIRGenExpr.cpp

@@ -257,11 +257,10 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr,
   assert(!cir::MissingFeatures::opTBAA());
 }
 
-void CIRGenFunction::emitStoreThroughBitfieldLValue(RValue src, LValue dst,
-                                                    mlir::Value &result) {
+mlir::Value CIRGenFunction::emitStoreThroughBitfieldLValue(RValue src, LValue dst) {
   assert(!cir::MissingFeatures::bitfields());
   cgm.errorNYI("bitfields");
-  result = {};
+  return {};
 }
 
 mlir::Value CIRGenFunction::emitToMemory(mlir::Value value, QualType ty) {

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp

@@ -847,7 +847,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       // 'An assignment expression has the value of the left operand after the
       // assignment...'.
       if (lhs.isBitField()) {
-        cgf.emitStoreThroughBitfieldLValue(RValue::get(rhs), lhs, rhs);
+        rhs = cgf.emitStoreThroughBitfieldLValue(RValue::get(rhs), lhs);
       } else {
         cgf.emitNullabilityCheck(lhs, rhs, e->getExprLoc());
         CIRGenFunction::SourceLocRAIIObject loc{

clang/lib/CIR/CodeGen/CIRGenFunction.h

@@ -579,8 +579,7 @@ class CIRGenFunction : public CIRGenTypeCache {
   /// is 'Ty'.
   void emitStoreThroughLValue(RValue src, LValue dst, bool isInit = false);
 
-  void emitStoreThroughBitfieldLValue(RValue src, LValue dst,
-                                      mlir::Value &result);
+  mlir::Value emitStoreThroughBitfieldLValue(RValue src, LValue dstresult);
 
   /// Given a value and its clang type, returns the value casted to its memory
   /// representation.