Restrict the safe member access to this pointer.

Author: rniwa

clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp

@@ -235,6 +235,11 @@ bool isExprToGetCheckedPtrCapableMember(const clang::Expr *E) {
   auto *ME = dyn_cast<MemberExpr>(E);
   if (!ME)
     return false;
+  auto *Base = ME->getBase();
+  if (!Base)
+    return false;
+  if (!isa<CXXThisExpr>(Base->IgnoreParenCasts()))
+    return false;
   auto *D = ME->getMemberDecl();
   if (!D)
     return false;

clang/test/Analysis/Checkers/WebKit/call-args-checked.cpp

@@ -44,6 +44,10 @@ struct WrapperObj {
     consume(checkedRef);
     // expected-warning@-1{{Call argument is unchecked and unsafe [alpha.webkit.UncheckedCallArgsChecker]}}
   }
+  void bar(WrapperObj& other) {
+    consume(other.checked);
+    // expected-warning@-1{{Call argument is unchecked and unsafe [alpha.webkit.UncheckedCallArgsChecker]}}
+  }
 };
 
 } // namespace call_args_checked

clang/test/Analysis/Checkers/WebKit/unchecked-local-vars.cpp

@@ -302,6 +302,12 @@ namespace member_var {
       // expected-warning@-1{{Local variable 'b' is unchecked and unsafe [alpha.webkit.UncheckedLocalVarsChecker]}}
       b->method();
     }
+
+    void bar(WrapperObj& wrapper) {
+      CheckedObj* ptr = &wrapper.checked;
+      // expected-warning@-1{{Local variable 'ptr' is unchecked and unsafe [alpha.webkit.UncheckedLocalVarsChecker]}}
+      ptr->method();
+    }
   };
 
 }