Skip to content

Commit d5d9fc7

Browse files
[llvm-debuginfo-analyzer] IR Reader.
Add a missing space between the offset and 'ptr' for a better layout. [004] 9 {Variable} 'CONSTANT' -> 'const INTEGER' [006] {Location} [007] {Entry} bregx 3 ptr %CONSTANT+0
1 parent f066249 commit d5d9fc7

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

llvm/lib/DebugInfo/LogicalView/Readers/LVIRReader.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,10 @@ std::string LVIRReader::getRegisterName(LVSmall Opcode,
317317
// Leaving it here, just for any specific needs.
318318
// LLVM_DEBUG({
319319
// dbgs() << "Printing Value: " << Operands[0] << " - "
320-
// << DbgValueRanges->getVariableName(Operands[0]) << "\n";
320+
// << ValueNameMap.getName(Operands[0]) << "\n";
321321
// });
322-
return ValueNameMap.getName(Operands[0]);
322+
// Add an extra space for a better layout when printing locations.
323+
return " " + ValueNameMap.getName(Operands[0]);
323324
}
324325

325326
llvm_unreachable("We shouldn't actually have any other reg types here!");

llvm/test/tools/llvm-debuginfo-analyzer/IR/06-ir-full-logical-view.test

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
; ONE-NEXT: [0x0000000010][004] 5 {Variable} 'CONSTANT' -> [0x000000003c]'const INTEGER'
4949
; ONE-NEXT: [0x0000000010][005] {Coverage} 100.00%
5050
; ONE-NEXT: [0x0000000000][006] {Location}
51-
; ONE-NEXT: [0x0000000000][007] {Entry} bregx 3ptr %CONSTANT+0
51+
; ONE-NEXT: [0x0000000000][007] {Entry} bregx 3 ptr %CONSTANT+0
5252
; ONE-NEXT: [0x0000000030][004] 5 {Line} '{{.*}}/general/test.cpp'
5353
; ONE-NEXT: [0x0000000030][004] {Code} 'store i32 7, ptr %CONSTANT, align 4, !dbg !32'
5454
; ONE-NEXT: [0x0000000034][004] 6 {Line} '{{.*}}/general/test.cpp'
@@ -58,15 +58,15 @@
5858
; ONE-NEXT: [0x0000000014][003] 2 {Parameter} 'ParamPtr' -> [0x0000000028]'INTPTR'
5959
; ONE-NEXT: [0x0000000014][004] {Coverage} 100.00%
6060
; ONE-NEXT: [0x0000000000][004] {Location}
61-
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 0ptr %ParamPtr.addr+0
61+
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 0 ptr %ParamPtr.addr+0
6262
; ONE-NEXT: [0x0000000018][003] 2 {Parameter} 'ParamUnsigned' -> [0x0000000034]'unsigned int'
6363
; ONE-NEXT: [0x0000000018][004] {Coverage} 100.00%
6464
; ONE-NEXT: [0x0000000000][004] {Location}
65-
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 1ptr %ParamUnsigned.addr+0
65+
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 1 ptr %ParamUnsigned.addr+0
6666
; ONE-NEXT: [0x000000001c][003] 2 {Parameter} 'ParamBool' -> [0x0000000038]'bool'
6767
; ONE-NEXT: [0x000000001c][004] {Coverage} 100.00%
6868
; ONE-NEXT: [0x0000000000][004] {Location}
69-
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 2ptr %ParamBool.addr+0
69+
; ONE-NEXT: [0x0000000000][005] {Entry} bregx 2 ptr %ParamBool.addr+0
7070
; ONE-NEXT: [0x0000000020][003] 4 {TypeAlias} 'INTEGER' -> [0x0000000024]'int'
7171
; ONE-NEXT: [0x0000000000][003] 2 {Line} '{{.*}}/general/test.cpp'
7272
; ONE-NEXT: [0x0000000000][003] {Code} '%retval = alloca i32, align 4'

llvm/test/tools/llvm-debuginfo-analyzer/IR/07-ir-debug-formats.test

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@
3535
; ONE-NEXT: [002] 2 {Function} extern not_inlined 'foo' -> 'int'
3636
; ONE-NEXT: [003] 2 {Parameter} 'ParamBool' -> 'bool'
3737
; ONE-NEXT: [004] {Location}
38-
; ONE-NEXT: [005] {Entry} bregx 2ptr %ParamBool.addr+0
38+
; ONE-NEXT: [005] {Entry} bregx 2 ptr %ParamBool.addr+0
3939
; ONE-NEXT: [003] 2 {Parameter} 'ParamPtr' -> 'INTPTR'
4040
; ONE-NEXT: [004] {Location}
41-
; ONE-NEXT: [005] {Entry} bregx 0ptr %ParamPtr.addr+0
41+
; ONE-NEXT: [005] {Entry} bregx 0 ptr %ParamPtr.addr+0
4242
; ONE-NEXT: [003] 2 {Parameter} 'ParamUnsigned' -> 'unsigned int'
4343
; ONE-NEXT: [004] {Location}
44-
; ONE-NEXT: [005] {Entry} bregx 1ptr %ParamUnsigned.addr+0
44+
; ONE-NEXT: [005] {Entry} bregx 1 ptr %ParamUnsigned.addr+0
4545
; ONE-NEXT: [003] {Block}
4646
; ONE-NEXT: [004] 5 {Variable} 'CONSTANT' -> 'const INTEGER'
4747
; ONE-NEXT: [006] {Location}
48-
; ONE-NEXT: [007] {Entry} bregx 3ptr %CONSTANT+0
48+
; ONE-NEXT: [007] {Entry} bregx 3 ptr %CONSTANT+0

0 commit comments

Comments
 (0)