review changes

Author: VigneshwarJ

clang/lib/Sema/SemaDecl.cpp

@@ -8715,11 +8715,12 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
   }
 
   // zero sized static arrays are not allowed in HIP device functions
-  if (getLangOpts().HIP &&
-      DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
-    if (QualType NextTy = NewVD->getType(); NextTy->isArrayType()) {
+  if (getLangOpts().HIP && LangOpts.CUDAIsDevice) {
+    if (FunctionDecl *FD = getCurFunctionDecl();
+        FD &&
+        (FD->hasAttr<CUDADeviceAttr>() || FD->hasAttr<CUDAGlobalAttr>())) {
       if (const ConstantArrayType *ArrayT =
-              getASTContext().getAsConstantArrayType(NextTy);
+              getASTContext().getAsConstantArrayType(T);
           ArrayT && ArrayT->isZeroSize()) {
         Diag(NewVD->getLocation(), diag::err_typecheck_zero_array_size) << 2;
       }

clang/test/SemaHIP/zero-sized-device-array.hip

@@ -7,6 +7,8 @@
 
 typedef float ZEROARR[0];
 
+float global_array[0];
+
 __global__ void global_fun() {
     extern __shared__ float externArray[];
     ZEROARR TypeDef; // expected-error {{zero-length arrays are not permitted in HIP device code}}