address feedback

Author: akuhlens

flang-rt/include/flang-rt/runtime/descriptor.h

@@ -227,7 +227,6 @@ class Descriptor {
   RT_API_ATTRS bool IsPointer() const {
     return raw_.attribute == CFI_attribute_pointer;
   }
-  RT_API_ATTRS bool IsAssociated() const { return raw_.base_addr != nullptr; }
   RT_API_ATTRS bool IsAllocatable() const {
     return raw_.attribute == CFI_attribute_allocatable;
   }

flang-rt/lib/runtime/derived-api.cpp

@@ -124,11 +124,9 @@ bool RTDEF(ExtendsTypeOf)(const Descriptor &a, const Descriptor &mold) {
   // F'23 16.9.86 p 5
   // If MOLD is unlimited polymorphic and is either a disassociated pointer or
   // unallocated allocatable variable, the result is true;
-  if ((mold.IsPointer() && !mold.IsAssociated()) ||
-      (mold.IsAllocatable() && !mold.IsAllocated())) {
+  if ((mold.IsPointer() || mold.IsAllocatable()) && !mold.IsAllocated()) {
     return true;
-  } else if ((a.IsPointer() && !a.IsAssociated()) ||
-      (a.IsAllocatable() && !a.IsAllocated())) {
+  } else if ((a.IsPointer() || a.IsAllocatable()) && !a.IsAllocated()) {
     return false;
   }
   auto aType{a.raw().type};

flang-rt/lib/runtime/pointer.cpp

@@ -259,7 +259,7 @@ int RTDEF(PointerDeallocatePolymorphic)(Descriptor &pointer,
 }
 
 bool RTDEF(PointerIsAssociated)(const Descriptor &pointer) {
-  return pointer.IsAssociated();
+  return pointer.raw().base_addr != nullptr;
 }
 
 bool RTDEF(PointerIsAssociatedWith)(