Define and reuse I64Ty and PtrTy in legalizeLifetimeIntrinsics function for better readability

Author: Icohedron

llvm/lib/Target/DirectX/DXILWriter/DXILWriterPass.cpp

@@ -59,6 +59,7 @@ class WriteDXILPass : public llvm::ModulePass {
 
 static void legalizeLifetimeIntrinsics(Module &M) {
   LLVMContext &Ctx = M.getContext();
+  Type *I64Ty = IntegerType::get(Ctx, 64);
   Intrinsic::ID LifetimeIIDs[2] = {Intrinsic::lifetime_start,
                                    Intrinsic::lifetime_end};
   for (Intrinsic::ID &IID : LifetimeIIDs) {
@@ -73,8 +74,8 @@ static void legalizeLifetimeIntrinsics(Module &M) {
     AttributeList Attr;
     Attr = Attr.addFnAttribute(Ctx, Attribute::NoUnwind);
     FunctionCallee LifetimeCallee = M.getOrInsertFunction(
-        Intrinsic::getBaseName(IID), Attr, Type::getVoidTy(Ctx),
-        IntegerType::get(Ctx, 64), PointerType::get(Ctx, 0));
+        Intrinsic::getBaseName(IID), Attr, Type::getVoidTy(Ctx), I64Ty,
+        PointerType::get(Ctx, 0));
 
     // Replace all calls to lifetime intrinsics with calls to the
     // LLVM 3.7-compliant version of the lifetime intrinsic
@@ -101,12 +102,11 @@ static void legalizeLifetimeIntrinsics(Module &M) {
           AI->getAllocationSize(CI->getDataLayout());
       assert(AllocSize.has_value() &&
              "Expected the allocation size of AllocaInst to be known");
-      CallInst *NewCI =
-          CallInst::Create(LifetimeCallee,
-                           {ConstantInt::get(IntegerType::get(Ctx, 64),
-                                             AllocSize.value().getFixedValue()),
-                            NoOpBitCast},
-                           "", CI->getIterator());
+      CallInst *NewCI = CallInst::Create(
+          LifetimeCallee,
+          {ConstantInt::get(I64Ty, AllocSize.value().getFixedValue()),
+           NoOpBitCast},
+          "", CI->getIterator());
       for (Attribute ParamAttr : CI->getParamAttributes(0))
         NewCI->addParamAttr(1, ParamAttr);