Skip to content

Commit d677fa6

Browse files
committed
Address comments.
1 parent d15fd3d commit d677fa6

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

libc/src/math/generic/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4097,7 +4097,6 @@ add_entrypoint_object(
40974097
HDRS
40984098
../asin.h
40994099
DEPENDS
4100-
libc.src.__support.FPUtil.fp_bits
41014100
libc.src.__support.FPUtil.double_double
41024101
libc.src.__support.FPUtil.dyadic_float
41034102
libc.src.__support.FPUtil.fenv_impl

libc/src/math/generic/asin.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ LLVM_LIBC_FUNCTION(double, asin, (double x)) {
146146

147147
// When |x| >= 0.5, we perform range reduction as follow:
148148
//
149-
// Assume further that 0.5 < x <= 1, and let:
149+
// Assume further that 0.5 <= x < 1, and let:
150150
// y = asin(x)
151151
// We will use the double angle formula:
152152
// cos(2y) = 1 - 2 sin^2(y)
@@ -174,7 +174,7 @@ LLVM_LIBC_FUNCTION(double, asin, (double x)) {
174174
// h = u - v_hi^2 = (sqrt(u) - v_hi) * (sqrt(u) + v_hi)
175175
// Then:
176176
// sqrt(u) = v_hi + h / (sqrt(u) + v_hi)
177-
// ~ v_hi + h / (2 * v_hi)
177+
// ~ v_hi + h / (2 * v_hi)
178178
// So we can use:
179179
// v_lo = h / (2 * v_hi).
180180
// Then,

libc/test/src/math/smoke/asin_test.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ TEST_F(LlvmLibcAsinTest, SpecialNumbers) {
1717
EXPECT_FP_EQ_WITH_EXCEPTION_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(sNaN),
1818
FE_INVALID);
1919
EXPECT_FP_EQ_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(aNaN));
20-
EXPECT_FP_EQ_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(aNaN));
2120
EXPECT_FP_EQ_ALL_ROUNDING(zero, LIBC_NAMESPACE::asin(zero));
2221
EXPECT_FP_EQ_ALL_ROUNDING(neg_zero, LIBC_NAMESPACE::asin(neg_zero));
2322
EXPECT_FP_EQ_ALL_ROUNDING(aNaN, LIBC_NAMESPACE::asin(inf));

0 commit comments

Comments
 (0)