@@ -10,7 +10,7 @@ Objective
10
10
11
11
This document provides an overview of an external tool to verify the protection
12
12
mechanisms implemented by Clang's *Control Flow Integrity * (CFI) schemes
13
- (``-fsanitize=cfi ``). This tool, provided a binary or DSO, should infer whether
13
+ (``-fsanitize=cfi ``). This tool, given a binary or DSO, should infer whether
14
14
indirect control flow operations are protected by CFI, and should output these
15
15
results in a human-readable form.
16
16
@@ -22,12 +22,12 @@ Location
22
22
========
23
23
24
24
This tool will be present as a part of the LLVM toolchain, and will reside in
25
- the " /llvm/tools/llvm-cfi-verify" directory, relative to the LLVM trunk. It will
25
+ the `` /llvm/tools/llvm-cfi-verify `` directory, relative to the LLVM trunk. It will
26
26
be tested in two methods:
27
27
28
28
- Unit tests to validate code sections, present in
29
- " /llvm/unittests/tools/llvm-cfi-verify" .
30
- - Integration tests, present in " /llvm/tools/clang/test/LLVMCFIVerify" . These
29
+ `` /llvm/unittests/tools/llvm-cfi-verify `` .
30
+ - Integration tests, present in `` /llvm/tools/clang/test/LLVMCFIVerify `` . These
31
31
integration tests are part of clang as part of a continuous integration
32
32
framework, ensuring updates to the compiler that reduce CFI coverage on
33
33
indirect control flow instructions are identified.
@@ -38,16 +38,16 @@ Background
38
38
This tool will continuously validate that CFI directives are properly
39
39
implemented around all indirect control flows by analysing the output machine
40
40
code. The analysis of machine code is important as it ensures that any bugs
41
- present in linker or compiler do not subvert CFI protections in the final
41
+ present in the linker or compiler do not subvert CFI protections in the final
42
42
shipped binary.
43
43
44
44
Unprotected indirect control flow instructions will be flagged for manual
45
- review. These unexpected control flows may simply have not been accounted for in
46
- the compiler implementation of CFI (e.g. indirect jumps to facilitate switch
45
+ review. These unexpected control flows may not have been accounted for in
46
+ the compiler implementation of CFI (e.g., indirect jumps to facilitate switch
47
47
statements may not be fully protected).
48
48
49
49
It may be possible in the future to extend this tool to flag unnecessary CFI
50
- directives (e.g. CFI directives around a static call to a non-polymorphic base
50
+ directives (e.g., CFI directives around a static call to a non-polymorphic base
51
51
type). This type of directive has no security implications, but may present
52
52
performance impacts.
53
53
@@ -66,7 +66,7 @@ the disassembly. A control flow graph would be generated from a small buffer of
66
66
the instructions surrounding the 'target' control flow instruction. If the
67
67
target instruction is branched-to, the fallthrough of the branch should be the
68
68
CFI trap (on x86, this is a ``ud2 `` instruction). If the target instruction is
69
- the fallthrough (i.e. immediately succeeds) of a conditional jump, the
69
+ the fallthrough (i.e., immediately succeeds) of a conditional jump, the
70
70
conditional jump target should be the CFI trap. If an indirect control flow
71
71
instruction does not conform to one of these formats, the target will be noted
72
72
as being CFI-unprotected.
@@ -76,7 +76,7 @@ fallthrough of a conditional jump), if the target represents a vcall that takes
76
76
arguments, these arguments may be pushed to the stack after the branch but
77
77
before the target instruction. In these cases, a secondary 'spill graph' in
78
78
constructed, to ensure the register argument used by the indirect jump/call is
79
- not spilled from the stack at any point in the interim period . If there are no
79
+ not spilled from the stack at any point in the interim. If there are no
80
80
spills that affect the target register, the target is marked as CFI-protected.
81
81
82
82
Other Design Notes
0 commit comments