Skip to content

Commit d719247

Browse files
committed
code review
1 parent 203317b commit d719247

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3312,7 +3312,7 @@ TEST(SignatureHelpTest, SkipExplicitObjectParameter) {
33123312
*Preamble, Inputs, MarkupKind::PlainText);
33133313
// TODO: We expect 1 signature here, with this signature
33143314
EXPECT_EQ(0U, Result.signatures.size());
3315-
// EXPECT_THAT(Result.signatures[0], AllOf(sig("([[A&&]], [[int]]) ->
3315+
// EXPECT_THAT(Result.signatures[0], AllOf(sig("([[auto&&]], [[int]]) ->
33163316
// void")));
33173317
}
33183318
}
@@ -4432,8 +4432,8 @@ TEST(CompletionTest, SkipExplicitObjectParameter) {
44324432

44334433
// TODO: llvm/llvm-project/146649
44344434
// This is incorrect behavior. Correct Result should be a variant of,
4435-
// c2: signature = (A&& self, int arg)
4436-
// snippet = (${1: A&& self}, ${2: int arg})
4435+
// c2: signature = (auto&& self, int arg)
4436+
// snippet = (${1: auto&& self}, ${2: int arg})
44374437
// c3: signature = (A self, int arg)
44384438
// snippet = (${1: A self}, ${2: int arg})
44394439

0 commit comments

Comments
 (0)