Skip to content

Commit d76fc7a

Browse files
committed
[clang] Change style of cwg960 test expectations to be more consistent with other tests.
1 parent c07e53d commit d76fc7a

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

clang/test/CXX/drs/cwg9xx.cpp

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,12 @@ class A {
100100
// Check lvalue ref vs rvalue ref vs pointer.
101101
virtual a& rvalue_ref();
102102
virtual a&& lvalue_ref();
103-
virtual a& rvalue_vs_lvalue_ref(); // expected-note{{overridden virtual function is here}}
104-
virtual a&& lvalue_vs_rvalue_ref(); // expected-note{{overridden virtual function is here}}
105-
virtual a& rvalue_ref_vs_pointer(); // expected-note{{overridden virtual function is here}}
106-
virtual a* pointer_vs_rvalue_ref(); // expected-note{{overridden virtual function is here}}
107-
virtual a&& lvalue_ref_vs_pointer(); // expected-note{{overridden virtual function is here}}
108-
virtual a* pointer_vs_lvalue_ref(); // expected-note{{overridden virtual function is here}}
103+
virtual a& rvalue_vs_lvalue_ref(); // #cwg960-A-rvalue_vs_lvalue_ref
104+
virtual a&& lvalue_vs_rvalue_ref(); // #cwg960-A-lvalue_vs_rvalue_ref
105+
virtual a& rvalue_ref_vs_pointer(); // #cwg960-A-rvalue_ref_vs_pointer
106+
virtual a* pointer_vs_rvalue_ref(); // #cwg960-A-pointer_vs_rvalue_ref
107+
virtual a&& lvalue_ref_vs_pointer(); // #cwg960-A-lvalue_ref_vs_pointer
108+
virtual a* pointer_vs_lvalue_ref(); // #cwg960-A-pointer_vs_lvalue_ref
109109
#endif
110110
};
111111

@@ -114,12 +114,30 @@ class B : A {
114114
// Check lvalue ref vs rvalue ref vs pointer.
115115
a& rvalue_ref() override;
116116
a&& lvalue_ref() override;
117-
a&& rvalue_vs_lvalue_ref() override; // expected-error{{virtual function 'rvalue_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a &')}}
118-
a& lvalue_vs_rvalue_ref() override; // expected-error{{virtual function 'lvalue_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a &&')}}
119-
a* rvalue_ref_vs_pointer() override; // expected-error{{virtual function 'rvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &')}}
120-
a& pointer_vs_rvalue_ref() override; // expected-error{{virtual function 'pointer_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a *')}}
121-
a* lvalue_ref_vs_pointer() override; // expected-error{{virtual function 'lvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &&')}}
122-
a&& pointer_vs_lvalue_ref() override; // expected-error{{virtual function 'pointer_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a *')}}
117+
118+
a&& rvalue_vs_lvalue_ref() override;
119+
// since-cxx11-error@-1 {{virtual function 'rvalue_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a &')}}
120+
// since-cxx11-note@#cwg960-A-rvalue_vs_lvalue_ref {{overridden virtual function is here}}
121+
122+
a& lvalue_vs_rvalue_ref() override;
123+
// since-cxx11-error@-1 {{virtual function 'lvalue_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a &&')}}
124+
// since-cxx11-note@#cwg960-A-lvalue_vs_rvalue_ref {{overridden virtual function is here}}
125+
126+
a* rvalue_ref_vs_pointer() override;
127+
// since-cxx11-error@-1 {{virtual function 'rvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &')}}
128+
// since-cxx11-note@#cwg960-A-rvalue_ref_vs_pointer {{overridden virtual function is here}}
129+
130+
a& pointer_vs_rvalue_ref() override;
131+
// since-cxx11-error@-1 {{virtual function 'pointer_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a *')}}
132+
// since-cxx11-note@#cwg960-A-pointer_vs_rvalue_ref {{overridden virtual function is here}}
133+
134+
a* lvalue_ref_vs_pointer() override;
135+
// since-cxx11-error@-1 {{virtual function 'lvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &&')}}
136+
// since-cxx11-note@#cwg960-A-lvalue_ref_vs_pointer {{overridden virtual function is here}}
137+
138+
a&& pointer_vs_lvalue_ref() override;
139+
// since-cxx11-error@-1 {{virtual function 'pointer_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a *')}}
140+
// since-cxx11-note@#cwg960-A-pointer_vs_lvalue_ref {{overridden virtual function is here}}
123141
#endif
124142
};
125143

0 commit comments

Comments
 (0)