Skip to content

Commit d7dcc10

Browse files
authored
[GitHub] Add review instructions for commit access requests (#168971)
As discussed in https://discourse.llvm.org/t/clarification-on-how-to-accept-commit-access-requests/88728, clarify reviewer instructions for how to accept commit access requests.
1 parent 0c9c62a commit d7dcc10

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

llvm/docs/DeveloperPolicy.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,10 @@ Most commonly these reviewers will provide the necessary approval, but approvals
526526
from other LLVM committers are also acceptable. Those reviewing the application are
527527
confirming that you have indeed had three patches committed, and that based on interactions
528528
on those reviews and elsewhere in the LLVM community they have no concern about you
529-
adhering to our Developer Policy and Code of Conduct.
529+
adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
530+
reasoning for accepting or rejecting the request, and finish with a clear statement such
531+
as "I approve of this request", "LGTM", or "I do not approve of this request".
532+
530533

531534
If approved, a GitHub invitation will be sent to your
532535
GitHub account. In case you don't get notification from GitHub, go to

llvm/utils/git/github-automation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,8 @@ def run(self) -> bool:
305305
* [{merged_prs} Merged Pull Requests]({merged_prs_url})
306306
* Top 3 Committers: {get_user_values_str(get_top_values(merged_by))}
307307
* Top 3 Reviewers: {get_user_values_str(get_top_values(reviewed_by))}
308+
309+
Reviewers should clearly state their reasoning for accepting or rejecting this request, and finish with a clear statement such as \"I approve of this request\", \"LGTM\", or \"I do not approve of this request\". Please review the instructions for [obtaining commit access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).
308310
"""
309311
self.issue.create_comment(textwrap.dedent(comment))
310312

0 commit comments

Comments
 (0)