Address code review comments

natedal · natedal · commit d81532b01458 · 2025-01-27T13:46:06.000-06:00
diff --git a/llvm/test/Transforms/AggressiveInstCombine/memchr.ll b/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
@@ -162,12 +162,11 @@ entry:
   ret ptr %memchr
 }
 
-
+; We want to check that the compiler still calls memchr if the length is non-constant:
 define ptr @test_memchr_non_constant_length2(i32 %x, i64 %len) {
 ; CHECK-LABEL: define ptr @test_memchr_non_constant_length2(
 ; CHECK-SAME: i32 [[X:%.*]], i64 [[LEN:%.*]]) {
 ; CHECK-NEXT:  [[ENTRY:.*:]]
-; CHECK-NEXT: ; We want to check that the compiler still calls memchr:
 ; CHECK-NEXT:    [[MEMCHR:%.*]] = call ptr @memchr(ptr @str, i32 [[X]], i64 [[LEN]])
 ; CHECK-NEXT:    ret ptr [[MEMCHR]]
 ;

Original file line number	Diff line number	Diff line change
`@@ -162,12 +162,11 @@ entry:`
`162`	`162`	`ret ptr %memchr`
`163`	`163`	`}`
`164`	`164`
`165`		`-`
	`165`	`+; We want to check that the compiler still calls memchr if the length is non-constant:`
`166`	`166`	`define ptr @test_memchr_non_constant_length2(i32 %x, i64 %len) {`
`167`	`167`	`; CHECK-LABEL: define ptr @test_memchr_non_constant_length2(`
`168`	`168`	`; CHECK-SAME: i32 [[X:%.]], i64 [[LEN:%.]]) {`
`169`	`169`	`; CHECK-NEXT: [[ENTRY:.*:]]`
`170`		`-; CHECK-NEXT: ; We want to check that the compiler still calls memchr:`
`171`	`170`	`; CHECK-NEXT: [[MEMCHR:%.*]] = call ptr @memchr(ptr @str, i32 [[X]], i64 [[LEN]])`
`172`	`171`	`; CHECK-NEXT: ret ptr [[MEMCHR]]`
`173`	`172`	`;`