Addressed style comments:

- Everything pointed out by @overmighty
- Fixed math.yaml to make sure it has all functions from upstream

TODO:
- Modify MPFRWrapper to work with acospi using older version of MPFR

Author: amemov

libc/config/linux/x86_64/entrypoints.txt

@@ -657,8 +657,8 @@ if(LIBC_TYPES_HAS_FLOAT16)
   list(APPEND TARGET_LIBM_ENTRYPOINTS
     # math.h C23 _Float16 entrypoints
     libc.src.math.acosf16
-    libc.src.math.acospif16
     libc.src.math.acoshf16
+    libc.src.math.acospif16
     libc.src.math.asinf16
     libc.src.math.asinhf16
     libc.src.math.canonicalizef16

libc/include/math.yaml

@@ -21,19 +21,26 @@ functions:
     arguments:
       - type: _Float16
     guard: LIBC_TYPES_HAS_FLOAT16
-  - name: acospif16
+  - name: acoshf
+    standards:
+      - stdc
+    return_type: float
+    arguments:
+      - type: float
+    name: acoshf16
     standards:
       - stdc
     return_type: _Float16
     arguments:
       - type: _Float16
     guard: LIBC_TYPES_HAS_FLOAT16
-  - name: acoshf
+    name: acospif16
     standards:
       - stdc
-    return_type: float
+    return_type: _Float16
     arguments:
-      - type: float
+      - type: _Float16
+    guard: LIBC_TYPES_HAS_FLOAT16
   - name: asin
     standards:
       - stdc
@@ -59,6 +66,13 @@ functions:
     return_type: float
     arguments:
       - type: float
+  - name: asinhf16
+    standards:
+      - stdc
+    return_type: _Float16
+    arguments:
+      - type: _Float16
+    guard: LIBC_TYPES_HAS_FLOAT16
   - name: atan
     standards:
       - stdc
@@ -86,6 +100,14 @@ functions:
     arguments:
       - type: long double
       - type: long double
+  - name: atan2f128
+    standards:
+      - stdc
+    return_type: float128
+    arguments:
+      - type: float128
+      - type: float128
+    guard: LIBC_TYPES_HAS_FLOAT128
   - name: atanf
     standards:
       - stdc
@@ -749,6 +771,15 @@ functions:
       - type: float
       - type: float
       - type: float
+  - name: fmaf16
+    standards:
+      - stdc
+    return_type: _Float16
+    arguments:
+      - type: _Float16
+      - type: _Float16
+      - type: _Float16
+    guard: LIBC_TYPES_HAS_FLOAT16
   - name: fmax
     standards:
       - stdc
@@ -1379,6 +1410,14 @@ functions:
     arguments:
       - type: float
       - type: float
+  - name: hypotf16
+    standards:
+      - stdc
+    return_type: _Float16
+    arguments:
+      - type: _Float16
+      - type: _Float16
+    guard: LIBC_TYPES_HAS_FLOAT16
   - name: ilogb
     standards:
       - stdc

libc/src/math/generic/acospif16.cpp

@@ -1,10 +1,9 @@
-//===-- Half-precision acospif16(x) function ------------------------------===//
+//===-- Half-precision acospi function ------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception.
 //
-//
 //===----------------------------------------------------------------------===//
 
 #include "src/math/acospif16.h"
@@ -40,7 +39,7 @@ LLVM_LIBC_FUNCTION(float16, acospif16, (float16 x)) {
       return x;
     }
 
-    // 1 < |x| <= +/-inf
+    // 1 < |x| <= +inf
     fputil::raise_except_if_required(FE_INVALID);
     fputil::set_errno_if_required(EDOM);
 

libc/test/src/math/smoke/acospif16_test.cpp

@@ -1,6 +1,5 @@
 //===-- Unittests for acospif16 -------------------------------------------===//
 //
-//
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception.