Skip to content

Commit d852ab7

Browse files
committed
refactor: EXPECT_FP_EQUAL(aNaN,...) -> EXPECT_FP_IS_NAN(...)
Signed-off-by: Krishna Pandey <[email protected]>
1 parent 2199765 commit d852ab7

File tree

3 files changed

+24
-28
lines changed

3 files changed

+24
-28
lines changed

libc/test/src/math/smoke/acoshf16_test.cpp

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,54 +15,51 @@
1515
using LlvmLibcAcoshf16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
1616

1717
TEST_F(LlvmLibcAcoshf16Test, SpecialNumbers) {
18-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acoshf16(aNaN));
18+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acoshf16(aNaN));
1919
EXPECT_MATH_ERRNO(0);
2020

21-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::acoshf16(sNaN), FE_INVALID);
21+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::acoshf16(sNaN), FE_INVALID);
2222
EXPECT_MATH_ERRNO(0);
2323

24-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::acoshf16(zero), FE_INVALID);
24+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::acoshf16(zero), FE_INVALID);
2525
EXPECT_MATH_ERRNO(EDOM);
2626

27-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acoshf16(neg_zero));
27+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acoshf16(neg_zero));
2828
EXPECT_MATH_ERRNO(EDOM);
2929

30-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::acoshf16(neg_zero),
31-
FE_INVALID);
30+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::acoshf16(neg_zero),
31+
FE_INVALID);
3232
EXPECT_MATH_ERRNO(EDOM);
3333

3434
EXPECT_FP_EQ(inf, LIBC_NAMESPACE::acoshf16(inf));
3535
EXPECT_MATH_ERRNO(0);
3636

37-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acoshf16(neg_inf));
37+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acoshf16(neg_inf));
3838
EXPECT_MATH_ERRNO(EDOM);
3939

40-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::acoshf16(neg_inf),
41-
FE_INVALID);
40+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::acoshf16(neg_inf),
41+
FE_INVALID);
4242
EXPECT_MATH_ERRNO(EDOM);
4343

4444
EXPECT_FP_EQ(zero, LIBC_NAMESPACE::acoshf16(
4545
LIBC_NAMESPACE::fputil::cast<float16>(1.0)));
4646
EXPECT_MATH_ERRNO(0);
4747

48-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acoshf16(
49-
LIBC_NAMESPACE::fputil::cast<float16>(0.5)));
48+
EXPECT_FP_IS_NAN(
49+
LIBC_NAMESPACE::acoshf16(LIBC_NAMESPACE::fputil::cast<float16>(0.5)));
5050
EXPECT_MATH_ERRNO(EDOM);
5151

52-
EXPECT_FP_EQ_WITH_EXCEPTION(
53-
aNaN,
52+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(
5453
LIBC_NAMESPACE::acoshf16(LIBC_NAMESPACE::fputil::cast<float16>(-1.0)),
5554
FE_INVALID);
5655
EXPECT_MATH_ERRNO(EDOM);
5756

58-
EXPECT_FP_EQ_WITH_EXCEPTION(
59-
aNaN,
57+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(
6058
LIBC_NAMESPACE::acoshf16(LIBC_NAMESPACE::fputil::cast<float16>(-2.0)),
6159
FE_INVALID);
6260
EXPECT_MATH_ERRNO(EDOM);
6361

64-
EXPECT_FP_EQ_WITH_EXCEPTION(
65-
aNaN,
62+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(
6663
LIBC_NAMESPACE::acoshf16(LIBC_NAMESPACE::fputil::cast<float16>(-3.0)),
6764
FE_INVALID);
6865
EXPECT_MATH_ERRNO(EDOM);

libc/test/src/math/smoke/acospif16_test.cpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,24 @@
1313

1414
using LlvmLibcAcospif16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
1515
TEST_F(LlvmLibcAcospif16Test, SpecialNumbers) {
16-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acospif16(aNaN));
16+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acospif16(aNaN));
1717
EXPECT_MATH_ERRNO(0);
1818

19-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::acospif16(sNaN),
20-
FE_INVALID);
19+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::acospif16(sNaN), FE_INVALID);
2120
EXPECT_MATH_ERRNO(0);
2221

2322
EXPECT_FP_EQ(zero, LIBC_NAMESPACE::acospif16(1.0f));
2423
EXPECT_MATH_ERRNO(0);
2524

26-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acospif16(inf));
25+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acospif16(inf));
2726
EXPECT_MATH_ERRNO(EDOM);
2827

29-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acospif16(neg_inf));
28+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acospif16(neg_inf));
3029
EXPECT_MATH_ERRNO(EDOM);
3130

32-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acospif16(2.0f));
31+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acospif16(2.0f));
3332
EXPECT_MATH_ERRNO(EDOM);
3433

35-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::acospif16(-2.0f));
34+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::acospif16(-2.0f));
3635
EXPECT_MATH_ERRNO(EDOM);
3736
}

libc/test/src/math/smoke/sinpif16_test.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
using LlvmLibcSinpif16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
1616

1717
TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
18-
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::sinpif16(sNaN), FE_INVALID);
18+
EXPECT_FP_IS_NAN_WITH_EXCEPTION(LIBC_NAMESPACE::sinpif16(sNaN), FE_INVALID);
1919
EXPECT_MATH_ERRNO(0);
2020

21-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(aNaN));
21+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::sinpif16(aNaN));
2222
EXPECT_MATH_ERRNO(0);
2323

2424
EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(zero));
@@ -27,10 +27,10 @@ TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
2727
EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(neg_zero));
2828
EXPECT_MATH_ERRNO(0);
2929

30-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(inf));
30+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::sinpif16(inf));
3131
EXPECT_MATH_ERRNO(EDOM);
3232

33-
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(neg_inf));
33+
EXPECT_FP_IS_NAN(LIBC_NAMESPACE::sinpif16(neg_inf));
3434
EXPECT_MATH_ERRNO(EDOM);
3535
}
3636

0 commit comments

Comments
 (0)