Skip to content

Commit d8979be

Browse files
committed
Fix an issue where we erroneously diagnose a [[noreturn]] function with warn_suggest_noreturn_function
1 parent cf10a09 commit d8979be

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

clang/lib/Sema/SemaDeclAttr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1976,8 +1976,8 @@ void clang::inferNoReturnAttr(Sema &S, const Decl *D) {
19761976
Diags.isIgnored(diag::warn_suggest_noreturn_function, FD->getLocation()))
19771977
return;
19781978

1979-
if (!FD->hasAttr<NoReturnAttr>() && !FD->hasAttr<InferredNoReturnAttr>() &&
1980-
isKnownToAlwaysThrow(FD)) {
1979+
if (!FD->hasAttr<NoReturnAttr>() && !FD->hasAttr<CXX11NoReturnAttr>() &&
1980+
!FD->hasAttr<InferredNoReturnAttr>() && isKnownToAlwaysThrow(FD)) {
19811981
NonConstFD->addAttr(InferredNoReturnAttr::CreateImplicit(S.Context));
19821982

19831983
// Emit a diagnostic suggesting the function being marked [[noreturn]].

0 commit comments

Comments
 (0)