Skip to content

Commit d947092

Browse files
committed
Address comments
1 parent 4914455 commit d947092

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,6 @@ Bug Fixes to Attribute Support
324324
is skipped, such as error recovery and code completion. (#GH153551)
325325
- Using ``[[gnu::cleanup(some_func)]]`` where some_func is annotated with
326326
``[[gnu::error("some error")]]`` now correctly triggers an error. (#GH146520)
327-
- Stop rejecting C++11-style attributes on the first argument of constructors in older
328-
standards. (#GH156809).
329327

330328
Bug Fixes to C++ Support
331329
^^^^^^^^^^^^^^^^^^^^^^^^
@@ -351,6 +349,8 @@ Bug Fixes to C++ Support
351349
authentication enabled. (#GH152601)
352350
- Fix the check for narrowing int-to-float conversions, so that they are detected in
353351
cases where converting the float back to an integer is undefined behaviour (#GH157067).
352+
- Stop rejecting C++11-style attributes on the first argument of constructors in older
353+
standards. (#GH156809).
354354

355355
Bug Fixes to AST Handling
356356
^^^^^^^^^^^^^^^^^^^^^^^^^

clang/lib/Parse/ParseDecl.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6007,10 +6007,9 @@ bool Parser::isConstructorDeclarator(bool IsUnqualified, bool DeductionGuide,
60076007

60086008
// A C++11 attribute here signals that we have a constructor, and is an
60096009
// attribute on the first constructor parameter.
6010-
if (getLangOpts().CPlusPlus &&
6011-
isCXX11AttributeSpecifier(/*Disambiguate*/ false,
6010+
if (isCXX11AttributeSpecifier(/*Disambiguate*/ false,
60126011
/*OuterMightBeMessageSend*/ true) !=
6013-
CXX11AttributeKind::NotAttributeSpecifier) {
6012+
CXX11AttributeKind::NotAttributeSpecifier) {
60146013
return true;
60156014
}
60166015

0 commit comments

Comments
 (0)