Address feedbacks

Author: mrcvtl

clang/include/clang/AST/Decl.h

@@ -1589,9 +1589,8 @@ class VarDecl : public DeclaratorDecl, public Redeclarable<VarDecl> {
     NonParmVarDeclBits.IsCXXCondDecl = true;
   }
 
-  /// Determine whether this variable is the compiler-generated '__range'
-  /// variable used to hold the range expression in a C++11 and later for-range
-  /// statement.
+  /// Whether this variable is the implicit '__range' variable in C++
+  /// range-based for loops.
   bool isCXXForRangeImplicitVar() const {
     return isa<ParmVarDecl>(this) ? false
                                   : NonParmVarDeclBits.IsCXXForRangeImplicitVar;

clang/lib/Sema/CheckExprLifetime.cpp

@@ -57,7 +57,6 @@ enum LifetimeKind {
 };
 using LifetimeResult =
     llvm::PointerIntPair<const InitializedEntity *, 3, LifetimeKind>;
-
 } // namespace
 
 /// Determine the declaration which an initialized entity ultimately refers to,
@@ -1344,7 +1343,8 @@ checkExprLifetimeImpl(Sema &SemaRef, const InitializedEntity *InitEntity,
       if (IsGslPtrValueFromGslTempOwner && DiagLoc.isValid()) {
 
         if (SemaRef.getLangOpts().CPlusPlus23) {
-          if (const VarDecl *VD = cast<VarDecl>(InitEntity->getDecl());
+          if (const VarDecl *VD =
+                  dyn_cast_if_present<VarDecl>(InitEntity->getDecl());
               VD && VD->isCXXForRangeImplicitVar())
             return false;
         }

clang/lib/Sema/SemaStmt.cpp

@@ -2374,9 +2374,6 @@ static bool FinishForRangeVarDecl(Sema &SemaRef, VarDecl *Decl, Expr *Init,
       SemaRef.ObjC().inferObjCARCLifetime(Decl))
     Decl->setInvalidDecl();
 
-  if (SemaRef.getLangOpts().CPlusPlus23)
-    SemaRef.currentEvaluationContext().InLifetimeExtendingContext = true;
-
   SemaRef.AddInitializerToDecl(Decl, Init, /*DirectInit=*/false);
   SemaRef.FinalizeDeclaration(Decl);
   SemaRef.CurContext->addHiddenDecl(Decl);