Skip to content

Commit d9b8042

Browse files
committed
Update testcase comments
Signed-off-by: John Lu <[email protected]>
1 parent 3a9f8de commit d9b8042

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

llvm/test/CodeGen/AMDGPU/shl64_reduce.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313
; Test range with metadata
1414
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
1515

16-
; FIXME: This case should be reduced, but SelectionDAG::computeKnownBits() cannot
17-
; determine the minimum from metadata in this case. Match current results
18-
; for now.
19-
2016
define i64 @shl_metadata(i64 %arg0, ptr %arg1.ptr) {
2117
; CHECK-LABEL: shl_metadata:
2218
; CHECK: ; %bb.0:
@@ -45,6 +41,7 @@ define i64 @shl_metadata_two_ranges(i64 %arg0, ptr %arg1.ptr) {
4541
ret i64 %shl
4642
}
4743

44+
; Known minimum is too low. Reduction must not be done.
4845
define i64 @shl_metadata_out_of_range(i64 %arg0, ptr %arg1.ptr) {
4946
; CHECK-LABEL: shl_metadata_out_of_range:
5047
; CHECK: ; %bb.0:
@@ -59,7 +56,7 @@ define i64 @shl_metadata_out_of_range(i64 %arg0, ptr %arg1.ptr) {
5956
}
6057

6158
; Bounds cannot be truncated to i32 when load is narrowed to i32.
62-
; Reduction not done.
59+
; Reduction must not be done.
6360
; Bounds were chosen so that if bounds were truncated to i32 the
6461
; known minimum would be 32 and the shl would be erroneously reduced.
6562
define i64 @shl_metadata_cant_be_narrowed_to_i32(i64 %arg0, ptr %arg1.ptr) {
@@ -75,6 +72,7 @@ define i64 @shl_metadata_cant_be_narrowed_to_i32(i64 %arg0, ptr %arg1.ptr) {
7572
ret i64 %shl
7673
}
7774

75+
; FIXME: This case should be reduced
7876
define <2 x i64> @shl_v2_metadata(<2 x i64> %arg0, ptr %arg1.ptr) {
7977
; CHECK-LABEL: shl_v2_metadata:
8078
; CHECK: ; %bb.0:
@@ -89,6 +87,7 @@ define <2 x i64> @shl_v2_metadata(<2 x i64> %arg0, ptr %arg1.ptr) {
8987
ret <2 x i64> %shl
9088
}
9189

90+
; FIXME: This case should be reduced
9291
define <3 x i64> @shl_v3_metadata(<3 x i64> %arg0, ptr %arg1.ptr) {
9392
; CHECK-LABEL: shl_v3_metadata:
9493
; CHECK: ; %bb.0:
@@ -105,6 +104,7 @@ define <3 x i64> @shl_v3_metadata(<3 x i64> %arg0, ptr %arg1.ptr) {
105104
ret <3 x i64> %shl
106105
}
107106

107+
; FIXME: This case should be reduced
108108
define <4 x i64> @shl_v4_metadata(<4 x i64> %arg0, ptr %arg1.ptr) {
109109
; CHECK-LABEL: shl_v4_metadata:
110110
; CHECK: ; %bb.0:

0 commit comments

Comments
 (0)