Skip to content

Commit d9dfec3

Browse files
Address review comments
1 parent 81a4729 commit d9dfec3

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

llvm/unittests/TargetParser/TargetParserTest.cpp

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1815,7 +1815,7 @@ AArch64ExtensionDependenciesBaseArchTestParams
18151815
{AArch64::ARMV9_6A, {"nofp", "fprcvt"}, {"fp-armv8", "fprcvt"}, {}},
18161816
{AArch64::ARMV9_6A, {"fprcvt", "nofp"}, {}, {"fp-armv8", "fprcvt"}},
18171817

1818-
// simd -> {aes, sha2, sha3, sm4, f8f16mm, f8f32mm}
1818+
// simd -> {aes, sha2, sha3, sm4, f8f16mm, f8f32mm, faminmax, lut, fp8}
18191819
{AArch64::ARMV8A, {"nosimd", "aes"}, {"neon", "aes"}, {}},
18201820
{AArch64::ARMV8A, {"aes", "nosimd"}, {}, {"neon", "aes"}},
18211821
{AArch64::ARMV8A, {"nosimd", "sha2"}, {"neon", "sha2"}, {}},
@@ -1828,21 +1828,19 @@ AArch64ExtensionDependenciesBaseArchTestParams
18281828
{AArch64::ARMV9_6A, {"f8f16mm", "nosimd"}, {}, {"neon", "f8f16mm"}},
18291829
{AArch64::ARMV9_6A, {"nosimd", "f8f32mm"}, {"neon", "f8f32mm"}, {}},
18301830
{AArch64::ARMV9_6A, {"f8f32mm", "nosimd"}, {}, {"neon", "f8f32mm"}},
1831-
1832-
// fp8 -> {fp8dot4, fp8dot2}
1833-
{AArch64::ARMV9_6A, {"nofp8", "fp8dot4"}, {"fp8", "fp8dot4"}, {}},
1834-
{AArch64::ARMV9_6A, {"fp8dot4", "nofp8"}, {}, {"fp8", "fp8dot4"}},
1835-
{AArch64::ARMV9_6A, {"nofp8", "fp8dot2"}, {"fp8", "fp8dot2"}, {}},
1836-
{AArch64::ARMV9_6A, {"fp8dot2", "nofp8"}, {}, {"fp8", "fp8dot2"}},
1837-
1838-
// simd -> {faminman, lut, fp8}}
18391831
{AArch64::ARMV9_6A, {"faminmax", "nosimd"}, {}, {"neon", "faminmax"}},
18401832
{AArch64::ARMV9_6A, {"nosimd", "faminmax"}, {"neon", "faminmax"}, {}},
18411833
{AArch64::ARMV9_6A, {"lut", "nosimd"}, {}, {"neon", "lut"}},
18421834
{AArch64::ARMV9_6A, {"nosimd", "lut"}, {"neon", "lut"}, {}},
18431835
{AArch64::ARMV9_6A, {"fp8", "nosimd"}, {}, {"neon", "fp8"}},
18441836
{AArch64::ARMV9_6A, {"nosimd", "fp8"}, {"neon", "fp8"}, {}},
18451837

1838+
// fp8 -> {fp8dot4, fp8dot2}
1839+
{AArch64::ARMV9_6A, {"nofp8", "fp8dot4"}, {"fp8", "fp8dot4"}, {}},
1840+
{AArch64::ARMV9_6A, {"fp8dot4", "nofp8"}, {}, {"fp8", "fp8dot4"}},
1841+
{AArch64::ARMV9_6A, {"nofp8", "fp8dot2"}, {"fp8", "fp8dot2"}, {}},
1842+
{AArch64::ARMV9_6A, {"fp8dot2", "nofp8"}, {}, {"fp8", "fp8dot2"}},
1843+
18461844
// simd -> {rdm, dotprod, fcma}
18471845
{AArch64::ARMV8A, {"nosimd", "rdm"}, {"neon", "rdm"}, {}},
18481846
{AArch64::ARMV8A, {"rdm", "nosimd"}, {}, {"neon", "rdm"}},
@@ -1988,7 +1986,6 @@ AArch64ExtensionDependenciesBaseArchTestParams
19881986
{AArch64::ARMV9_6A, {"fp8dot4", "nofp8"}, {}, {"fp8", "fp8dot4"}},
19891987
{AArch64::ARMV9_6A, {"nofp8", "fp8dot2"}, {"fp8", "fp8dot2"}, {}},
19901988
{AArch64::ARMV9_6A, {"fp8dot2", "nofp8"}, {}, {"fp8", "fp8dot2"}},
1991-
19921989
{AArch64::ARMV9_6A,
19931990
{"nofp8", "ssve-fp8dot4"},
19941991
{"fp8", "ssve-fp8dot4"},

0 commit comments

Comments
 (0)