[CodeGen] Use insert idiom in CFIInstrInserter instead of find [nfc] (#170760)

preames · web-flow · commit da06d9eeafe2 · 2025-12-04T16:52:14.000-08:00
diff --git a/llvm/lib/CodeGen/CFIInstrInserter.cpp b/llvm/lib/CodeGen/CFIInstrInserter.cpp
@@ -279,10 +279,8 @@ void CFIInstrInserter::calculateOutgoingCFAInfo(MBBCFAInfo &MBBInfo) {
       }
       if (CSRReg || CSROffset) {
         CSRSavedLocation Loc(CSRReg, CSROffset);
-        auto It = CSRLocMap.find(CFI.getRegister());
-        if (It == CSRLocMap.end()) {
-          CSRLocMap.insert({CFI.getRegister(), Loc});
-        } else if (It->second != Loc) {
+        auto [It, Inserted] = CSRLocMap.insert({CFI.getRegister(), Loc});
+        if (!Inserted && It->second != Loc) {
           reportFatalInternalError(
               "Different saved locations for the same CSR");
         }

Original file line number	Diff line number	Diff line change
`@@ -279,10 +279,8 @@ void CFIInstrInserter::calculateOutgoingCFAInfo(MBBCFAInfo &MBBInfo) {`
`279`	`279`	`}`
`280`	`280`	`if (CSRReg \|\| CSROffset) {`
`281`	`281`	`CSRSavedLocation Loc(CSRReg, CSROffset);`
`282`		`- auto It = CSRLocMap.find(CFI.getRegister());`
`283`		`- if (It == CSRLocMap.end()) {`
`284`		`- CSRLocMap.insert({CFI.getRegister(), Loc});`
`285`		`- } else if (It->second != Loc) {`
	`282`	`+ auto [It, Inserted] = CSRLocMap.insert({CFI.getRegister(), Loc});`
	`283`	`+ if (!Inserted && It->second != Loc) {`
`286`	`284`	`reportFatalInternalError(`
`287`	`285`	`"Different saved locations for the same CSR");`
`288`	`286`	`}`