Skip to content

Commit da61e6d

Browse files
committed
[symbolizer] Update Release notes.
Also add post-commit changes from commit #71ba852
1 parent b6521e8 commit da61e6d

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

llvm/docs/CommandGuide/llvm-addr2line.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ Here are some of those differences:
3636
- ``llvm-addr2line`` parses options from the environment variable
3737
``LLVM_ADDR2LINE_OPTS`` instead of from ``LLVM_SYMBOLIZER_OPTS``.
3838

39+
- ``llvm-addr2line`` accepts an address with a '+' prefix ie `+0x00777fff`
40+
this is not valid in ``llvm-symbolizer``
41+
3942
SEE ALSO
4043
--------
4144

llvm/docs/ReleaseNotes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ Changes to the LLVM tools
265265
* llvm-strip now supports continuing to process files on encountering an error.
266266
* In llvm-objcopy/llvm-strip's ELF port, `--discard-locals` and `--discard-all` now allow and preserve symbols referenced by relocations.
267267
([#47468](https://github.com/llvm/llvm-project/issues/47468))
268+
* llvm-addr2line now supports a `+` prefix when specifying an address.
268269

269270
Changes to LLDB
270271
---------------------------------

llvm/test/tools/llvm-symbolizer/symbol-search.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ RUN: llvm-addr2line --obj=%p/Inputs/symbols.so func_01+0A | FileCheck --check-pr
6666

6767
# If '+' is not preceded by a symbol, it is part of a symbol name, not an offset separator.
6868
RUN: llvm-symbolizer --obj=%p/Inputs/symbols.so +0x1138 | FileCheck --check-prefix=NONEXISTENT %s
69-
# in addr2line address starting with a `+` sign is a valid address
69+
# In addr2line address starting with a `+` sign is a valid address.
7070
RUN: llvm-addr2line --obj=%p/Inputs/symbols.so +0x1138 | FileCheck --check-prefix=CODE-CMD %s
7171

7272
# Show that C++ mangled names may be specified.

llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ static Error parseCommand(StringRef BinaryName, bool IsAddr2Line,
238238
bool StartsWithDigit = std::isdigit(AddrSpec.front());
239239

240240
// GNU addr2line assumes the address is hexadecimal and allows a redundant
241-
// "0x" or "0X" prefix or with an optional `+` sign; do the same for
241+
// "0x", "0X" prefix or an optional `+` sign; do the same for
242242
// compatibility.
243243
if (IsAddr2Line) {
244244
AddrSpec.consume_front_insensitive("0x") ||

0 commit comments

Comments
 (0)