Skip to content

Commit dae013d

Browse files
committed
address comment
1 parent b0366ed commit dae013d

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

llvm/include/llvm/CodeGen/SelectionDAGNodes.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ class SDValue {
213213
inline bool isTargetOpcode() const;
214214
inline bool isMachineOpcode() const;
215215
inline bool isUndef() const;
216-
inline bool isPoison() const;
217216
inline unsigned getMachineOpcode() const;
218217
inline const DebugLoc &getDebugLoc() const;
219218
inline void dump() const;
@@ -698,9 +697,6 @@ END_TWO_BYTE_PACK()
698697
return NodeType == ISD::UNDEF || NodeType == ISD::POISON;
699698
}
700699

701-
/// Returns true if the node type is POISON.
702-
bool isPoison() const { return NodeType == ISD::POISON; }
703-
704700
/// Test if this node is a memory intrinsic (with valid pointer information).
705701
bool isMemIntrinsic() const { return SDNodeBits.IsMemIntrinsic; }
706702

@@ -1274,8 +1270,6 @@ inline bool SDValue::isUndef() const {
12741270
return Node->isUndef();
12751271
}
12761272

1277-
inline bool SDValue::isPoison() const { return Node->isPoison(); }
1278-
12791273
inline bool SDValue::use_empty() const {
12801274
return !Node->hasAnyUseOfValue(ResNo);
12811275
}

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6242,7 +6242,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
62426242
return getNode(OpOpcode, DL, VT, N1.getOperand(0), Flags);
62436243
}
62446244

6245-
if (N1.isPoison())
6245+
if (OpOpcode == ISD::POISON)
62466246
return getPOISON(VT);
62476247

62486248
if (N1.isUndef())
@@ -6266,7 +6266,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
62666266
return getNode(ISD::ZERO_EXTEND, DL, VT, N1.getOperand(0), Flags);
62676267
}
62686268

6269-
if (N1.isPoison())
6269+
if (OpOpcode == ISD::POISON)
62706270
return getPOISON(VT);
62716271

62726272
if (N1.isUndef())

0 commit comments

Comments
 (0)