Skip to content

Commit db5e836

Browse files
committed
Respond to PR feedback.
../llvm/test/tools/llvm-objdump/DXContainer/input-output-signatures.yaml
1 parent 0c5a64c commit db5e836

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

llvm/test/tools/llvm-objdump/DXContainer/input-output-signatures.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# RUN: yaml2obj %s -o %t
2-
# RUN: llvm-objdump -p %t | FileCheck %s
2+
# RUN: llvm-objdump -p %t | FileCheck %s --match-full-lines --strict-whitespace
3+
4+
# This test covers llvm-objdump printing private headers for the ISG1, OSG1, and
5+
# PSG1 "parts" of the DX container file format. The test uses a few absurdly
6+
# large values and long string names to ensure that the columns in the printed
7+
# table widen correctly.
8+
39
--- !dxcontainer
410
Header:
511
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,

llvm/tools/llvm-objdump/DXContainerDump.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ void DXContainerDumper::printSignature(const DirectX::Signature &S) {
9595
enumToStringRef(El.CompType, dxbc::getSigComponentTypes()).size());
9696
}
9797

98-
// Print Column headers
98+
// Print Column headers.
9999
OS << "; ";
100100
OS << left_justify("Name", LongestName) << " ";
101101
OS << right_justify("Index", LongestIndex) << " ";
@@ -147,7 +147,6 @@ void DXContainerDumper::printPrivateHeaders() {
147147
OS << ";\n";
148148
}
149149
}
150-
151150
} // namespace
152151

153152
std::unique_ptr<objdump::Dumper> llvm::objdump::createDXContainerDumper(

0 commit comments

Comments
 (0)