fixed review issues

Author: balazske

clang-tools-extra/clang-tidy/bugprone/CastToStructCheck.cpp

@@ -17,14 +17,10 @@ namespace clang::tidy::bugprone {
 
 namespace {
 
-AST_MATCHER(Type, charType) {
-  return Node.isCharType();
-}
-AST_MATCHER(Type, unionType) {
-  return Node.isUnionType();
-}
+AST_MATCHER(Type, charType) { return Node.isCharType(); }
+AST_MATCHER(Type, unionType) { return Node.isUnionType(); }
 
-}
+} // namespace
 
 CastToStructCheck::CastToStructCheck(StringRef Name, ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context),
@@ -49,9 +45,7 @@ void CastToStructCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
 void CastToStructCheck::registerMatchers(MatchFinder *Finder) {
   auto FromPointee =
       qualType(hasUnqualifiedDesugaredType(type().bind("FromType")),
-               unless(voidType()),
-               unless(charType()),
-               unless(unionType()))
+               unless(voidType()), unless(charType()), unless(unionType()))
           .bind("FromPointee");
   auto ToPointee =
       qualType(hasUnqualifiedDesugaredType(
@@ -77,7 +71,8 @@ void CastToStructCheck::check(const MatchFinder::MatchResult &Result) {
   if (FromType == ToType)
     return;
 
-  auto CheckNameIgnore = [this](const std::string &FromName, const std::string &ToName) {
+  auto CheckNameIgnore = [this](const std::string &FromName,
+                                const std::string &ToName) {
     bool FromMatch = false;
     for (auto [Idx, Regex] : llvm::enumerate(IgnoredCastsRegex)) {
       if (Idx % 2 == 0) {
@@ -93,10 +88,9 @@ void CastToStructCheck::check(const MatchFinder::MatchResult &Result) {
   if (CheckNameIgnore(FromPtr->getAsString(), ToPtr->getAsString()))
     return;
 
-  diag(FoundCastExpr->getExprLoc(),
-       "casting a %0 pointer to a "
-       "%1 pointer and accessing a field can lead to memory "
-       "access errors or data corruption")
+  diag(FoundCastExpr->getExprLoc(), "casting a %0 pointer to a "
+                                    "%1 pointer can lead to memory "
+                                    "access errors or data corruption")
       << *FromPtr << *ToPtr;
 }
 

clang-tools-extra/clang-tidy/bugprone/CastToStructCheck.h

@@ -25,6 +25,7 @@ class CastToStructCheck : public ClangTidyCheck {
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
   bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
+    // C++ has different options for casting that make such a check less useful.
     return !LangOpts.CPlusPlus;
   }
 

clang-tools-extra/docs/clang-tidy/checks/bugprone/cast-to-struct.rst

@@ -34,16 +34,6 @@ types.
      s = (struct S1 *)calloc(1, sizeof(struct S1)); // no warning
    }
 
-Limitations
------------
-
-The check does not run on `C++` code.
-
-C-style casts are discouraged in C++ and should be converted to more type-safe
-casts. The ``reinterpreted_cast`` is used for the most unsafe cases and
-indicates by itself a potentially dangerous operation. Additionally, inheritance
-and dynamic types would make such a check less useful.
-
 Options
 -------