resolve comments

Author: mingmingl-llvm

llvm/lib/Analysis/StaticDataProfileInfo.cpp

@@ -29,9 +29,12 @@ static bool hasExplicitSectionName(const GlobalVariable &GVar) {
 AnnotationKind getAnnotationKind(const GlobalVariable &GV) {
   if (GV.isDeclarationForLinker())
     return AnnotationKind::DeclForLinker;
+  // Skip 'llvm.'-prefixed global variables conservatively because they are
+  // often handled specially,
   StringRef Name = GV.getName();
   if (Name.starts_with("llvm."))
     return AnnotationKind::ReservedName;
+  // Respect user-specified custom data sections.
   if (hasExplicitSectionName(GV))
     return AnnotationKind::ExplicitSection;
   return AnnotationKind::AnnotationOK;

llvm/lib/CodeGen/StaticDataSplitter.cpp

@@ -130,10 +130,8 @@ StaticDataSplitter::getConstant(const MachineOperand &Op,
   if (Op.isGlobal()) {
     // Find global variables with local linkage.
     const GlobalVariable *GV = getLocalLinkageGlobalVariable(Op.getGlobal());
-    // Skip 'llvm.'-prefixed global variables conservatively because they are
-    // often handled specially, and skip those not in static data
-    // sections.
-    if (!GV || GV->getName().starts_with("llvm.") ||
+    // Skip those not eligible for annotation or not in static data sections.
+    if (!GV || !llvm::memprof::IsAnnotationOK(*GV) ||
         !inStaticDataSection(*GV, TM))
       return nullptr;
     return GV;