Skip to content

Commit dd069cd

Browse files
committed
save adapterData for assembly breakpoints
1 parent 3a012ac commit dd069cd

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lldb/tools/lldb-dap/SourceBreakpoint.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include "BreakpointBase.h"
1111
#include "DAP.h"
1212
#include "JSONUtils.h"
13+
#include "ProtocolUtils.h"
1314
#include "lldb/API/SBBreakpoint.h"
1415
#include "lldb/API/SBFileSpecList.h"
1516
#include "lldb/API/SBFrame.h"
@@ -44,7 +45,7 @@ llvm::Error SourceBreakpoint::SetBreakpoint(const protocol::Source &source) {
4445
return llvm::createStringError(llvm::inconvertibleErrorCode(),
4546
"Invalid line number.");
4647

47-
if (source.sourceReference) {
48+
if (IsAssemblySource(source)) {
4849
// Breakpoint set by assembly source.
4950
std::optional<lldb::addr_t> raw_addr =
5051
m_dap.GetSourceReferenceAddress(*source.sourceReference);

lldb/tools/lldb-dap/SourceBreakpoint.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ class SourceBreakpoint : public Breakpoint {
5050
uint32_t GetColumn() const { return m_column; }
5151

5252
protected:
53+
llvm::Error SetAssemblyBreakpoint(const protocol::Source &source);
54+
llvm::Error SetPathBreakpoint(const protocol::Source &source);
55+
5356
// logMessage part can be either a raw text or an expression.
5457
struct LogMessagePart {
5558
LogMessagePart(llvm::StringRef text, bool is_expr)

0 commit comments

Comments
 (0)