review

Author: optimisan

llvm/include/llvm/Passes/CodeGenPassBuilder.h

@@ -1092,7 +1092,7 @@ void CodeGenPassBuilder<Derived, TargetMachineT>::addRegAllocPass(
       addPass(RAGreedyPass());
       break;
     default:
-      report_fatal_error("register allocator not supported yet.", false);
+      report_fatal_error("register allocator not supported yet", false);
     }
     return;
   }

llvm/lib/Passes/PassBuilder.cpp

@@ -1418,12 +1418,12 @@ parseRegAllocGreedyFilterFunc(PassBuilder &PB, StringRef Params) {
     return RAGreedyPass::Options();
   }
   std::optional<RegAllocFilterFunc> Filter = PB.parseRegAllocFilter(Params);
-  if (!Filter) {
-    return make_error<StringError>(
-        formatv("invalid regallocgreedy register filter '{0}' ", Params).str(),
-        inconvertibleErrorCode());
+  if (Filter) {
+    return RAGreedyPass::Options{*Filter, Params};
   }
-  return RAGreedyPass::Options{*Filter, Params};
+  return make_error<StringError>(
+      formatv("invalid regallocgreedy register filter '{0}' ", Params).str(),
+      inconvertibleErrorCode());
 }
 
 } // namespace