Skip to content

Commit ddd4974

Browse files
authored
[clang] [test] Improve XFAIL patterns for aarch64 msvc (#153397)
Unless relevant (which it very seldom is), avoid checking specifically for the "pc" vendor field; mingw environments often use "w64" as vendor - but not always. In this case, this test has been passing in mingw configurations lately; the previous XFAIL pattern would cause the test to unexpectedly succeed if running with a triple with a "pc" vendor field. Instead reinstate the checking for an -msvc environment here; this essentially reverts 8e029d9 (and the related typo fix 301f3da). I'm not sure how 8e029d9 concluded that this issue affected the gnu ABI (mingw) as well; I rechecked building that commit, and at that point, this test did pass for an aarch64 mingw target. (Due to the -pc- triple, the false positive XFAIL match hasn't been noticed before.)
1 parent f494131 commit ddd4974

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

clang/test/CodeGen/c-strings.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
// MSABI: @f4.x = internal global %struct.s { ptr @"??_C@_05CJBACGMB@hello?$AA@" }
1616
// CHECK: @x = {{(dso_local )?}}global [3 x i8] c"ola", align [[ALIGN]]
1717

18-
// XFAIL: target=aarch64-pc-windows-{{.*}}, target=arm64ec-pc-windows-{{.*}}
19-
// Arm64 aligns arrays to either 32-bit or 64-bit boundaries, which fails
18+
// XFAIL: target=aarch64-{{.*}}-windows-msvc, target=arm64ec-{{.*}}-windows-msvc
19+
// Arm64 in MSVC mode aligns arrays to either 32-bit or 64-bit boundaries, which fails
2020
// various checks above, since ALIGN is derived from the alignment of a single
2121
// i8, which is still 1.
2222

0 commit comments

Comments
 (0)