Skip to content

Commit ddf173d

Browse files
committed
[TableGen][NFC] Parenthesize parameters in GIMT_Encode2/4/8 macros
And avoid unnecessary casts.
1 parent bddfa1b commit ddf173d

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTable.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -53,26 +53,26 @@ constexpr StringLiteral EncodeMacroName = "GIMT_Encode";
5353
void emitEncodingMacrosDef(raw_ostream &OS) {
5454
OS << "#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__\n"
5555
<< "#define " << EncodeMacroName << "2(Val)"
56-
<< " uint8_t(Val), uint8_t((uint16_t)Val >> 8)\n"
56+
<< " uint8_t(Val), uint8_t((Val) >> 8)\n"
5757
<< "#define " << EncodeMacroName << "4(Val)"
58-
<< " uint8_t(Val), uint8_t((uint32_t)Val >> 8), "
59-
"uint8_t((uint32_t)Val >> 16), uint8_t((uint32_t)Val >> 24)\n"
58+
<< " uint8_t(Val), uint8_t((Val) >> 8), "
59+
"uint8_t((Val) >> 16), uint8_t((Val) >> 24)\n"
6060
<< "#define " << EncodeMacroName << "8(Val)"
61-
<< " uint8_t(Val), uint8_t((uint64_t)Val >> 8), "
62-
"uint8_t((uint64_t)Val >> 16), uint8_t((uint64_t)Val >> 24), "
63-
"uint8_t((uint64_t)Val >> 32), uint8_t((uint64_t)Val >> 40), "
64-
"uint8_t((uint64_t)Val >> 48), uint8_t((uint64_t)Val >> 56)\n"
61+
<< " uint8_t(Val), uint8_t((Val) >> 8), "
62+
"uint8_t((Val) >> 16), uint8_t((Val) >> 24), "
63+
"uint8_t(uint64_t(Val) >> 32), uint8_t(uint64_t(Val) >> 40), "
64+
"uint8_t(uint64_t(Val) >> 48), uint8_t(uint64_t(Val) >> 56)\n"
6565
<< "#else\n"
6666
<< "#define " << EncodeMacroName << "2(Val)"
67-
<< " uint8_t((uint16_t)Val >> 8), uint8_t(Val)\n"
67+
<< " uint8_t((Val) >> 8), uint8_t(Val)\n"
6868
<< "#define " << EncodeMacroName << "4(Val)"
69-
<< " uint8_t((uint32_t)Val >> 24), uint8_t((uint32_t)Val >> 16), "
70-
"uint8_t((uint32_t)Val >> 8), uint8_t(Val)\n"
69+
<< " uint8_t((Val) >> 24), uint8_t((Val) >> 16), "
70+
"uint8_t((Val) >> 8), uint8_t(Val)\n"
7171
<< "#define " << EncodeMacroName << "8(Val)"
72-
<< " uint8_t((uint64_t)Val >> 56), uint8_t((uint64_t)Val >> 48), "
73-
"uint8_t((uint64_t)Val >> 40), uint8_t((uint64_t)Val >> 32), "
74-
"uint8_t((uint64_t)Val >> 24), uint8_t((uint64_t)Val >> 16), "
75-
"uint8_t((uint64_t)Val >> 8), uint8_t(Val)\n"
72+
<< " uint8_t(uint64_t(Val) >> 56), uint8_t(uint64_t(Val) >> 48), "
73+
"uint8_t(uint64_t(Val) >> 40), uint8_t(uint64_t(Val) >> 32), "
74+
"uint8_t((Val) >> 24), uint8_t((Val) >> 16), "
75+
"uint8_t((Val) >> 8), uint8_t(Val)\n"
7676
<< "#endif\n";
7777
}
7878

0 commit comments

Comments
 (0)