Address review feedback

Author: Jeffrey Tan

lldb/test/API/tools/lldb-dap/stackTraceCompilerGeneratedCode/TestDAP_stackTraceCompilerGeneratedCode.py

@@ -10,7 +10,6 @@
 
 
 class TestDAP_stackTraceCompilerGeneratedCode(lldbdap_testcase.DAPTestCaseBase):
-    @skipIfWindows
     def test_non_leaf_frame_compiler_generate_code(self):
         """
         Test that non-leaf frames with compiler-generated code are properly resolved.
@@ -65,3 +64,4 @@ def test_non_leaf_frame_compiler_generate_code(self):
         # Verify that this didn't happen - the path should be a real file path.
         foo_path = foo_frame.get("source", {}).get("path")
         self.assertNotIn("`", foo_path, "Expected foo source path to not contain `")
+        self.continue_to_exit()

lldb/test/API/tools/lldb-dap/stackTraceCompilerGeneratedCode/main.c

@@ -4,14 +4,16 @@ void bar() {
 
 void at_line_zero() {}
 
+int foo();
+
+int main(int argc, char const *argv[]) {
+  foo();
+  return 0;
+}
+
 int foo() {
   bar(); // foo call bar
 #line 0 "test.cpp"
   at_line_zero();
   return 0;
 }
-
-int main(int argc, char const *argv[]) {
-  foo();
-  return 0;
-}

lldb/tools/lldb-dap/DAP.cpp

@@ -657,15 +657,6 @@ std::optional<protocol::Source> DAP::ResolveSource(const lldb::SBFrame &frame) {
   if (!frame.IsValid())
     return std::nullopt;
 
-  // IMPORTANT: Get line entry from symbol context, NOT from PC address.
-  // When a frame's PC points to a return address (the instruction
-  // after a call), that address may have line number 0 for compiler generated
-  // code.
-  //
-  // EXAMPLE: If PC is at 0x1004 (frame return address after the call
-  // instruction) with no line info, but 0x1003 (in the middle of previous call
-  // instruction) is at line 42, symbol context returns line 42.
-
   const lldb::SBLineEntry frame_line_entry = frame.GetLineEntry();
   if (DisplayAssemblySource(debugger, frame_line_entry)) {
     const lldb::SBAddress frame_pc = frame.GetPCAddress();