Require that the generated functions return DecodeStatus

Author: s-barannikov

llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp

@@ -107,14 +107,16 @@ static DecodeStatus DecodeFPCSCRegisterClass(MCInst &Inst, uint64_t RegNo,
 }
 #define DecodeFPICRegisterClass DecodeFPCSCRegisterClass
 
-static void DecodeCCRCRegisterClass(MCInst &Inst,
-                                    const MCDisassembler *Decoder) {
+static DecodeStatus DecodeCCRCRegisterClass(MCInst &Inst,
+                                            const MCDisassembler *Decoder) {
   Inst.addOperand(MCOperand::createReg(M68k::CCR));
+  return DecodeStatus::Success;
 }
 
-static void DecodeSRCRegisterClass(MCInst &Inst,
-                                   const MCDisassembler *Decoder) {
+static DecodeStatus DecodeSRCRegisterClass(MCInst &Inst,
+                                           const MCDisassembler *Decoder) {
   Inst.addOperand(MCOperand::createReg(M68k::SR));
+  return DecodeStatus::Success;
 }
 
 static DecodeStatus DecodeImm32(MCInst &Inst, uint64_t Imm, uint64_t Address,

llvm/utils/TableGen/DecoderEmitter.cpp

@@ -1127,7 +1127,8 @@ void DecoderTableBuilder::emitBinaryParser(raw_ostream &OS, indent Indent,
     if (IgnoreNonDecodableOperands)
       return;
     assert(!OpInfo.Decoder.empty());
-    OS << Indent << OpInfo.Decoder << "(MI, Decoder);\n";
+    OS << Indent << "if (!Check(S, " << OpInfo.Decoder << "(MI, Decoder)))\n"
+       << Indent << "  return MCDisassembler::Fail;\n";
     return;
   }